From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 80EA161332 for ; Tue, 13 Oct 2020 11:16:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B8EFC76D for ; Tue, 13 Oct 2020 11:15:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id ECBECC777 for ; Tue, 13 Oct 2020 11:15:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AF92B45D1F for ; Tue, 13 Oct 2020 11:15:47 +0200 (CEST) To: Proxmox VE development discussion , Stoiko Ivanov References: <20201012153458.18685-1-s.ivanov@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Tue, 13 Oct 2020 11:15:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20201012153458.18685-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.137 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lio.pm] Subject: [pve-devel] applied-series: [PATCH storage 0/2] LIO: fix tainted config and minor cleanup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2020 09:16:18 -0000 On 12.10.20 17:34, Stoiko Ivanov wrote: > > This patchset follows the fix in 609f117ff24d2cff6b155e1d4b1175ceebe5bd7b. > Since several operations rely on values read from the remote target's > LIO config (which is tainted), this patchset untaints the settings, which are > actually needed (and stores only those), while reading the config. > > The second patch removes two small left-over statements, which confused me > while debugging. > > Tested very roughly (adding disks, create/rollback snapshot, remove disk) on > a VM backed by a LIO-iSCSI target. > > Stoiko Ivanov (2): > LIO: untaint values read from remote config > LIO: drop unused statements > > PVE/Storage/LunCmd/LIO.pm | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) > applied series, thanks!