From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 95240746DE for ; Wed, 1 Jun 2022 12:28:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 855D01D4A0 for ; Wed, 1 Jun 2022 12:27:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 16BB41D495 for ; Wed, 1 Jun 2022 12:27:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DCC9C439A2 for ; Wed, 1 Jun 2022 12:27:32 +0200 (CEST) Message-ID: Date: Wed, 1 Jun 2022 12:27:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20220502140505.3082374-1-a.lauterer@proxmox.com> From: Aaron Lauterer In-Reply-To: <20220502140505.3082374-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.370 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.764 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager] ceph install wizard: fix #3597: don't autofill network X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2022 10:28:03 -0000 Can someone take a look at this? Patch should still apply. On 5/2/22 16:05, Aaron Lauterer wrote: > By not auto filling the Ceph public network we can avoid accidential > clicks on 'Next' which will cause the first Mon to be created with a > potentially wrong network. While that is fixable, it is tedious and can > be easily avoided by making the user always select the network to use. > > Signed-off-by: Aaron Lauterer > --- > www/manager6/ceph/CephInstallWizard.js | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js > index 59458b0d..bebfc319 100644 > --- a/www/manager6/ceph/CephInstallWizard.js > +++ b/www/manager6/ceph/CephInstallWizard.js > @@ -372,6 +372,7 @@ Ext.define('PVE.ceph.CephInstallWizard', { > name: 'network', > value: '', > fieldLabel: 'Public Network IP/CIDR', > + autoSelect: false, > bind: { > allowBlank: '{configuration}', > },