From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3205C72986 for ; Fri, 2 Jul 2021 15:14:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 18F7D98FA for ; Fri, 2 Jul 2021 15:13:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5A9D398C0 for ; Fri, 2 Jul 2021 15:13:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 23FAB404DF for ; Fri, 2 Jul 2021 15:13:47 +0200 (CEST) Message-ID: Date: Fri, 2 Jul 2021 15:13:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Dietmar Maurer References: <20210624081802.2090614-1-dietmar@proxmox.com> <20210624081802.2090614-2-dietmar@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210624081802.2090614-2-dietmar@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.547 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, httpserver.pm] Subject: [pve-devel] applied: [PATCH pve-manager] ui: implement OpenId login X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2021 13:14:21 -0000 On 24.06.21 10:17, Dietmar Maurer wrote: > --- > PVE/HTTPServer.pm | 4 +- > www/manager6/Utils.js | 8 +++ > www/manager6/window/LoginWindow.js | 105 ++++++++++++++++++++++++++++- > 3 files changed, 114 insertions(+), 3 deletions(-) > > applied, thanks! just FYI: I squashed in a few fixes though, for one the gettext usage was broken as things like `gettext('' + variable)` cannot work (would never wind a translation) and the scanner in proxmox-i18n cannot detect such things either. One must use either `Ext.String.format((gettext("bla bla: {0}"), variable)` or add the variable after the gettext call, depending on use-case. Also factored out the `openid_login_param` helper to proxmox-widget toolkit as `getOpenIDRedirectionAuthorization`, also fixed some casing (we prefer camelCase over snake_case in JS for new code[0]). [0]: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Casing