From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8592794FC1 for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 16:44:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6492533D42 for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 16:44:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 16:44:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0C7AC449F9 for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 16:44:30 +0200 (CEST) Message-ID: <ba21f955-dcfb-4192-acf9-be21f44d7001@proxmox.com> Date: Thu, 11 Apr 2024 16:44:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Markus Frank <m.frank@proxmox.com> References: <20240411104822.832432-1-m.frank@proxmox.com> <20240411104822.832432-2-m.frank@proxmox.com> Content-Language: en-GB From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20240411104822.832432-2-m.frank@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [machine.pm, qemuserver.pm, qemu.pm] Subject: [pve-devel] applied: Re: [PATCH qemu-server v9 1/3] fix #3784: config: Parameter for guest vIOMMU + test-cases X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 11 Apr 2024 14:44:31 -0000 On 11/04/2024 12:48, Markus Frank wrote: > vIOMMU enables the option to passthrough pci devices to L2 VMs > in L1 VMs via Nested Virtualisation and adds an extra isolation. > > Uses the new property-string from the "config: define machine schema > as property-string"-commit to add the viommu option to the machine > parameter. > > Currently there are two vIOMMU implementation in QEMU to choose: > intel or virtio > > Virtio-iommu is more recent but less used in production than intel-iommu. > > The assert_valid_machine_property function prevents using intel-iommu with > i440fx. > > Signed-off-by: Markus Frank <m.frank@proxmox.com> > --- > PVE/API2/Qemu.pm | 2 ++ > PVE/QemuServer.pm | 12 +++++++++++ > PVE/QemuServer/Machine.pm | 17 ++++++++++++++- > test/cfg2cmd/i440fx-viommu-intel.conf | 2 ++ > test/cfg2cmd/i440fx-viommu-virtio.conf | 1 + > test/cfg2cmd/i440fx-viommu-virtio.conf.cmd | 25 ++++++++++++++++++++++ > test/cfg2cmd/q35-viommu-intel.conf | 1 + > test/cfg2cmd/q35-viommu-intel.conf.cmd | 23 ++++++++++++++++++++ > test/cfg2cmd/q35-viommu-virtio.conf | 1 + > test/cfg2cmd/q35-viommu-virtio.conf.cmd | 23 ++++++++++++++++++++ > 10 files changed, 106 insertions(+), 1 deletion(-) > create mode 100644 test/cfg2cmd/i440fx-viommu-intel.conf > create mode 100644 test/cfg2cmd/i440fx-viommu-virtio.conf > create mode 100644 test/cfg2cmd/i440fx-viommu-virtio.conf.cmd > create mode 100644 test/cfg2cmd/q35-viommu-intel.conf > create mode 100644 test/cfg2cmd/q35-viommu-intel.conf.cmd > create mode 100644 test/cfg2cmd/q35-viommu-virtio.conf > create mode 100644 test/cfg2cmd/q35-viommu-virtio.conf.cmd > > applied, thanks!