From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 465638E63F for ; Fri, 11 Nov 2022 19:22:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 27044694D for ; Fri, 11 Nov 2022 19:22:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 11 Nov 2022 19:22:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AA281433F0 for ; Fri, 11 Nov 2022 19:22:34 +0100 (CET) Message-ID: Date: Fri, 11 Nov 2022 19:22:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion , Stefan Sterz References: <20221111150527.538248-1-s.sterz@proxmox.com> <20221111150527.538248-3-s.sterz@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221111150527.538248-3-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [asciidoc-pve.in] Subject: Re: [pve-devel] [PATCH docs v2 2/2] asciidoc-pve: ignore anchor names in curly braces X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2022 18:22:36 -0000 Am 11/11/2022 um 16:05 schrieb Stefan Sterz: > previously the scanner would detect some `onlineHelp` keys that are > set via CBind as anchor names. this would cause it to fail, as they > cannot be present anywhere in the documentation. no valid anchor name > can be wrapped in curly braces, as they need to be valid xml names. > hence it should be safe to just ignore all keys wrapped in curly > braces. >=20 > Signed-off-by: Stefan Sterz > --- > asciidoc-pve.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/asciidoc-pve.in b/asciidoc-pve.in > index d638a38..c536371 100644 > --- a/asciidoc-pve.in > +++ b/asciidoc-pve.in > @@ -465,7 +465,7 @@ sub scan_extjs_file { > debug("scan-extjs $filename"); > =20 > while(defined(my $line =3D <$fh>)) { > - if ($line =3D~ m/\s+onlineHelp:\s*[\'\"](.*?)[\'\"]/) { > + if ($line =3D~ m/\s+onlineHelp:\s*[\'\"]([^{].*?[^}])[\'\"]/) { IIUC this indirectly raised the minimum length of references to two chara= cters, not a deal breaker IMO as I don't really expect two characters to be used= anytime soon (maybe with unicode =F0=9F=A4=94=F0=9F=A7=A0=F0=9F=92=AD x)), but ma= ybe hint it in the commit message. > my $blockid =3D $1; > my $link =3D $fileinfo->{blockid_target}->{default}->{$blockid}; > die "undefined blockid '$blockid' ($filename, line $.)\n"