From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8A11F941A6 for ; Wed, 21 Sep 2022 09:59:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 78E4D24936 for ; Wed, 21 Sep 2022 09:58:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 21 Sep 2022 09:58:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C95534030F for ; Wed, 21 Sep 2022 09:58:36 +0200 (CEST) Message-ID: Date: Wed, 21 Sep 2022 09:58:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Thunderbird/105.0 To: Proxmox VE development discussion , Dominik Csapak References: <20220920145043.801188-1-d.csapak@proxmox.com> Content-Language: en-GB From: Thomas Lamprecht In-Reply-To: <20220920145043.801188-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.830 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.702 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] fix net regex in qm cleanup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2022 07:59:07 -0000 I initially read this as like it was a recent (code) cleanup that broke it. Fabian already applied it, so only two suggestion as for how to improve this for a next similar time.. subject: "qm: fix net regex in 'cleanup' command" Am 20/09/2022 um 16:50 schrieb Dominik Csapak: > the '+' needs to be in the brackets, otherwise '$1' is not the right id > Add Fixes: 3ea84aeb7c75d7b0bfbd9cb04440ad00072bfe0c > Signed-off-by: Dominik Csapak > --- > PVE/CLI/qm.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm > index 6a2e161..ca5d25f 100755 > --- a/PVE/CLI/qm.pm > +++ b/PVE/CLI/qm.pm > @@ -809,7 +809,7 @@ __PACKAGE__->register_method({ > # we have to cleanup the tap devices after a crash > > foreach my $opt (keys %$conf) { > - next if $opt !~ m/^net(\d)+$/; > + next if $opt !~ m/^net(\d+)$/; > my $interface = $1; > PVE::Network::tap_unplug("tap${vmid}i${interface}"); > }