From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CEE7185CC4 for ; Tue, 21 Dec 2021 11:41:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BB2B127FBF for ; Tue, 21 Dec 2021 11:41:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4CB2627FB1 for ; Tue, 21 Dec 2021 11:41:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 28C694551E for ; Tue, 21 Dec 2021 11:41:20 +0100 (CET) Message-ID: Date: Tue, 21 Dec 2021 11:41:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak References: <20211220113300.3090910-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211220113300.3090910-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: Re: [PATCH novnc] add patches to workaround fullscreen issue in android app X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 10:41:50 -0000 On 20/12/2021 12:33, Dominik Csapak wrote: > patch 15 hides the fullscreen button, > patch 16 make the error message dismissable > > Signed-off-by: Dominik Csapak > --- > ...-button-on-isFullscreen-get-variable.patch | 39 +++++++++++++++ > debian/patches/0017-make-error-hideable.patch | 47 +++++++++++++++++++ > debian/patches/series | 2 + > 3 files changed, 88 insertions(+) > create mode 100644 debian/patches/0016-hide-fullscreen-button-on-isFullscreen-get-variable.patch > create mode 100644 debian/patches/0017-make-error-hideable.patch > > now with the 1.3 rebase done first this applied cleanly, thanks! FYI: I adapted the commit message so that the patch references are correct there. IMO the "make error dismissable" should be upstreamed in some form, not sure if clicking on it is the best general solution, as that can make copying an error text hard, but either a X (text-)button or the like would surely be great for them too.