From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E91FC1FF164 for <inbox@lore.proxmox.com>; Fri, 25 Apr 2025 14:22:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9F236323B6; Fri, 25 Apr 2025 14:22:57 +0200 (CEST) Message-ID: <b96190d1-7023-4156-94ec-07d84e9dd886@proxmox.com> Date: Fri, 25 Apr 2025 14:22:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Christoph Heiss <c.heiss@proxmox.com> References: <20250422162739.255641-1-m.koeppl@proxmox.com> <20250422162739.255641-5-m.koeppl@proxmox.com> <D9DZZFX6Q8HP.1MHACYAF6HFFX@proxmox.com> Content-Language: en-US From: =?UTF-8?Q?Michael_K=C3=B6ppl?= <m.koeppl@proxmox.com> In-Reply-To: <D9DZZFX6Q8HP.1MHACYAF6HFFX@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [rust-lang.org, proxmox.com] Subject: Re: [pve-devel] [PATCH pve-installer 4/6] run rustfmt X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On 4/23/25 13:56, Christoph Heiss wrote: > Have you checked out the latest commit (952832147)? > > These are apparently the "old" 2021 edition rules which are being > applied here - latest master is on the 2024 edition for some time now > [0]. The changes here are the exact reverse of some of the changes done > in the follow-up tree-wide formatting commit [1]. > > (Also, running `cargo fmt` on latest master does not produce any > changes, FWIW. So this should not be necessary - that's what caught me.) > > [0] https://git.proxmox.com/?p=pve-installer.git;a=commitdiff;h=c305be5e > [1] https://git.proxmox.com/?p=pve-installer.git;a=commitdiff;h=a1575df4 > Hi, thanks for having a look and for your feedback! It seems this stems from a configuration issue with my Neovim. For some reason the rustfmt used by my editor plugin did not pick up the edition = "2024" in rustfmt.toml. FWIW, it did work when I instead set style_edition = "2024", which allows explicitly setting the style used for formatting according to the Rust documentation [0]. I suppose it's more of a configuration error on my side, though. I checked again to ensure the other patches are not affected. I suppose this one could just be omitted? Or should I send a new series? [0] https://doc.rust-lang.org/edition-guide/rust-2024/rustfmt-style-edition.html _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel