From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0CCA9CAF8 for ; Wed, 16 Aug 2023 11:45:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EB98E13B41 for ; Wed, 16 Aug 2023 11:45:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 16 Aug 2023 11:45:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BC44B400DE; Wed, 16 Aug 2023 11:45:32 +0200 (CEST) Message-ID: Date: Wed, 16 Aug 2023 11:45:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Filip Schauer References: <20230816082514.15425-1-f.schauer@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20230816082514.15425-1-f.schauer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH manager] fix #4663: Prevent Web UI reload on cert order for other node X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2023 09:45:34 -0000 semantically the patch looks good to me, but please check our style guide: https://pve.proxmox.com/wiki/Javascript_Style_Guide i know that the surrounding code isn't correctly formatted that way, but for new code please don't use single line if statements On 8/16/23 10:25, Filip Schauer wrote: > While it makes sense to reload the Web UI after ordering a certificate > for the same node, it is unnecessary to reload the Web UI when ordering > a certificate for a different node. > > Signed-off-by: Filip Schauer > --- > This change has been tested by ordering a valid Let's Encrypt > certificate for another node. This was done by temporarily exposing port > 80 of the node through a Cloudflare Tunnel. The results indicated that > there was no need to reload the current panel. > > www/manager6/node/ACME.js | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js > index 0642e7c5..122487c1 100644 > --- a/www/manager6/node/ACME.js > +++ b/www/manager6/node/ACME.js > @@ -523,6 +523,8 @@ Ext.define('PVE.node.ACME', { > > orderFinished: function(success) { > if (!success) return; > + // reload only if the Web UI is open on the same node that the cert was ordered for > + if (this.getView().nodename !== Proxmox.NodeName) return; > var txt = gettext('pveproxy will be restarted with new certificates, please reload the GUI!'); > Ext.getBody().mask(txt, ['pve-static-mask']); > // reload after 10 seconds automatically