From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9075B1FF16F for ; Fri, 15 Nov 2024 12:45:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F106311BFC; Fri, 15 Nov 2024 12:45:00 +0100 (CET) Message-ID: Date: Fri, 15 Nov 2024 12:44:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion References: <20241114093226.814530-1-d.csapak@proxmox.com> <20241114093226.814530-3-d.csapak@proxmox.com> <3d2ed5bd-e00c-4452-a60e-eb7a8cbf8ce1@proxmox.com> <78b274cf-2412-4290-90c5-a5c84bd9a4fa@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <78b274cf-2412-4290-90c5-a5c84bd9a4fa@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage v5 02/12] plugin: dir: implement import content type X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 11/15/24 12:24, Fiona Ebner wrote: > On 15.11.24 12:16 PM, Fiona Ebner wrote: >> On 14.11.24 10:32 AM, Dominik Csapak wrote: >>> + >>> + my ($vtype, $name, undef, undef, undef, undef, $fmt) = $class->parse_volname($volname); >>> + die "invalid content type '$vtype'\n" if $vtype ne 'import'; >>> + die "invalid format\n" if $fmt ne 'ova' && $fmt ne 'ovf'; >> >> The $IMPORT_EXT_RE_1 regex doesn't include 'ova' anymore. Is it still >> wanted here? > > Okay, I guess strictly speaking it would go into the next patch ;) ah ok, this probably happened on some rebase since i probably have to send a v6 anyway, i'd move the ova check in the next patch that includes ova in the IMPORT_EXT_RE_1 ? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel