From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id CA1511FF183
	for <inbox@lore.proxmox.com>; Wed,  2 Jul 2025 14:36:08 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 93D9A19DF2;
	Wed,  2 Jul 2025 14:36:46 +0200 (CEST)
Message-ID: <b8ff4e44-ea07-48ec-87b3-93fcf4f1218f@proxmox.com>
Date: Wed, 2 Jul 2025 14:36:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
 Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20250602110730.156144-1-f.ebner@proxmox.com>
 <5c0de667-97fa-4c50-b41d-83b05b8e7777@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <5c0de667-97fa-4c50-b41d-83b05b8e7777@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.028 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.232 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] applied: [PATCH v2 qemu] block/gluster: provider more
 context for deprecation warning
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Am 25.06.25 um 19:18 schrieb Thomas Lamprecht:
> Am 02.06.25 um 13:07 schrieb Fiona Ebner:
>> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>
>> Changes in v2:
>> * Instead of removing the warning, provide more context.
>>
>>  block/gluster.c | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/block/gluster.c b/block/gluster.c
>> index c3a9555591..71c4a60b02 100644
>> --- a/block/gluster.c
>> +++ b/block/gluster.c
>> @@ -816,7 +816,11 @@ static int qemu_gluster_open(BlockDriverState *bs,  QDict *options,
>>          goto out;
>>      }
>>  
>> -    warn_report_once("'gluster' is deprecated");
>> +    warn_report_once("Native 'gluster' support will be deprecated and removed"
>> +                     " in Proxmox VE 9.");
>> +    warn_report_once("Before upgrading, switch to accessing your Gluster"
>> +                     " storage as a directory storage or migrate to another"
>> +                     " storage type.");
>>  
>>      filename = qemu_opt_get(opts, GLUSTER_OPT_FILENAME);
>>  
> 
> Acked-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> 
> can you please apply this on the stable-bookworm and upload
> a new version so that we can get this warning out over the
> next few weeks? Maybe there are some stable fixes that make
> a bump more worthwhile, but no hard feelings there.

Applied adding in your trailers and uploaded a new version now.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel