From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CC31273604; Fri, 18 Jun 2021 09:08:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BBAA723B22; Fri, 18 Jun 2021 09:07:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 02B9223B16; Fri, 18 Jun 2021 09:07:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BE3C44357E; Fri, 18 Jun 2021 09:07:51 +0200 (CEST) To: pbs-devel@lists.proxmox.com, Wolfgang Bumiller , Proxmox VE development discussion References: <639063913.1294.1623999369597@webmail.proxmox.com> From: Fabian Ebner Message-ID: Date: Fri, 18 Jun 2021 09:07:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.877 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.254 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [pbs-devel] [PATCH v6 proxmox-apt 04/11] add check_repositories function X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 07:08:22 -0000 Am 18.06.21 um 08:58 schrieb Fabian Ebner: > Am 18.06.21 um 08:56 schrieb Wolfgang Bumiller: >> >>> On 06/18/2021 8:53 AM Fabian Ebner wrote: >>> >>> Am 18.06.21 um 08:44 schrieb Wolfgang Bumiller: >>>> >>>>> On 06/18/2021 8:42 AM Fabian Ebner wrote: >>>>>>> +            Some((last, rest)) => match rest.split_last() { >>>>>>> +                Some((second_to_last, _rest)) => { >>>>>>> +                    (*last == "org" && *second_to_last == "debian") >>>>>>> +                        || (*last == "com" && *second_to_last == >>>>>>> "proxmox") >>>>>>> +                } >>>>>>> +                None => false, >>>>>>> +            }, >>>>>>> +            None => false, >>>>>>> +        }; >>>>>>> + >>>>>>> +        for uri in self.uris.iter() { >>>>>>> +            if let Some(host) = host_from_uri(uri) { >>>>>>> +                let domains = host.split('.').collect(); >>>>>> >>>>>> ^ But instead of building a vector here, why not just do: >>>>>> >>>>>>        if host == "proxmox.com" || host.ends_with(".proxmox.com") >>>>>>            || host == "debian.org" || host.ends_with(".debian.org") >>>>>>        { >>>>>>            ... >>>>>>        } >>>>>> >>>>> >>>>> Misses FQDNs? >>>> >>>> Such as? >>>> >>> >>> http://security.debian.org. >> >> Why is that not caught by `.ends_with(".debian.org")`? >> > > Because of the final dot. But it is likely very uncommon and simply > splitting by '.' leads to false results with e.g. > http://security..debian.org too, so it might not be worth worrying about... > Sorry, should've been http://security.debian..org > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > >