From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 251521FF133 for ; Mon, 27 Apr 2026 15:45:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 03CC21FC7F; Mon, 27 Apr 2026 15:45:27 +0200 (CEST) Message-ID: Date: Mon, 27 Apr 2026 15:44:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-manager 1/1] ui: fix typo in comment To: Erik Fastermann , pve-devel@lists.proxmox.com References: <20260422093634.71367-1-e.fastermann@proxmox.com> <20260422093634.71367-2-e.fastermann@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260422093634.71367-2-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777297398325 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FULRYIVLB436QD3AESJDSS3LRB3X3CS2 X-Message-ID-Hash: FULRYIVLB436QD3AESJDSS3LRB3X3CS2 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The commit title could include a second prefix like 'pci map:' then it's clearer where the typo was fixed. Note that it's preferred to avoid sending a cover letter when it's only a stand-alone patch. In rare cases, it can be fine, if the cover letter includes additional information that cannot easily be included in the patch itself (e.g. long test output), but most often such extra information can also be added below the three dashes if it should not land in git history. Am 24.04.26 um 9:24 AM schrieb Erik Fastermann: > Signed-off-by: Erik Fastermann > --- > www/manager6/dc/PCIMapView.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/dc/PCIMapView.js b/www/manager6/dc/PCIMapView.js > index 6ea23a45..969ad2ea 100644 > --- a/www/manager6/dc/PCIMapView.js > +++ b/www/manager6/dc/PCIMapView.js > @@ -20,7 +20,7 @@ Ext.define('PVE.dc.PCIMapView', { > data.forEach((entry) => { > ids[entry.id] = entry; > }); > - // extract the mdev property from the global entry and insert to the individiual entries, > + // extract the mdev property from the global entry and insert to the individual entries, Pre-existing, but the sentence still sounds a bit off to me. Maybe we can use "and add it to the..." or "and set it for the..." instead? > // so we can reuse the normal checking logic > let mdev; > me.getRootNode()?.cascade(function (rec) {