From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CEBFA1FF170 for <inbox@lore.proxmox.com>; Tue, 19 Nov 2024 11:06:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B29CA1E997; Tue, 19 Nov 2024 11:06:16 +0100 (CET) Message-ID: <b8048705-0e89-4480-9249-b100540a1e26@proxmox.com> Date: Tue, 19 Nov 2024 11:06:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stoiko Ivanov <s.ivanov@proxmox.com>, Stefan Hanreich <s.hanreich@proxmox.com> References: <20241112155425.196432-1-s.hanreich@proxmox.com> <20241112155425.196432-4-s.hanreich@proxmox.com> <20241118195217.7ae60257@rosa.proxmox.com> Content-Language: en-US From: =?UTF-8?Q?Hannes_D=C3=BCrr?= <h.duerr@proxmox.com> In-Reply-To: <20241118195217.7ae60257@rosa.proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-docs v2 4/4] sdn: add documentation for isolated ports option X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> I like your changes, but I would adapt the description more to the bridge manpage [0]. [0] https://www.man7.org/linux/man-pages/man8/bridge.8.html On 11/18/24 19:52, Stoiko Ivanov wrote: > On Tue, 12 Nov 2024 16:54:25 +0100 > Stefan Hanreich <s.hanreich@proxmox.com> wrote: > >> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com> >> --- >> pvesdn.adoc | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/pvesdn.adoc b/pvesdn.adoc >> index 39de80f..b1f2578 100644 >> --- a/pvesdn.adoc >> +++ b/pvesdn.adoc >> @@ -383,6 +383,11 @@ Tag:: The unique VLAN or VXLAN ID >> VLAN Aware:: Enables vlan-aware option on the interface, enabling configuration >> in the guest. >> >> +Isolate Ports:: Sets the isolated flag for all members of this port, except for >> +the bridge port. This means that every port can only send traffic to the bridge >> +port. In order for this setting to take effect, you need to restart the VMs >> +that have interfaces on the VNet. >> + > Reading through the VNet docs - I'd rename bridge port to 'interface' and > members to guest ports. - maybe like this: > ``` > Isolate Ports:: Sets the isolated flag for all guest ports of this interface, > but not for the interface itself. This means that guests cannot send traffic to > each other. In order for this setting to take effect, you need to restart the > affected guest. > ``` This means that guests cannot send traffic to each other -> This means guests can only send traffic to non-isolated guests > > >> >> [[pvesdn_config_subnet]] >> Subnets > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel