From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 8E1711FF0AA
	for <inbox@lore.proxmox.com>; Tue, 03 Nov 2026 14:38:27 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id DC120218A8;
	Tue, 03 Nov 2026 14:38:25 +0100 (CET)
Message-ID: <b743984f-6c06-4302-8843-e0cce72b24e3@proxmox.com>
Date: Tue, 3 Nov 2026 14:38:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH pve-manager] ui: tag menu: show cluster name instead of
 undefined in title
To: Jonas Theisen <j.theisen@proxmox.com>, pve-devel@lists.proxmox.com
References: <20261030100700.82807-1-j.theisen@proxmox.com>
 <20261030100700.82807-2-j.theisen@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20261030100700.82807-2-j.theisen@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1793713102183
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.329 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: WJP4JK22TSACRRZS3B73LRTA72KHTYCZ
X-Message-ID-Hash: WJP4JK22TSACRRZS3B73LRTA72KHTYCZ
X-MailFrom: d.csapak@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

same comment regarding clustername as the other patch,
instead of fixing the clustername, we should simply remove that part here

on guests we also don't show neither the nodename nor the clustername
for example

On 10/30/26 11:07 AM, Jonas Theisen wrote:
> The tag context menu appends the node name to its title if a cluster
> name is set, but no node name is ever passed to it, so clustered
> setups show "(undefined)". Use the cluster name instead, like the
> datacenter context menu does.
> 
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
> ---
>   www/manager6/dc/CmdMenu.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/dc/CmdMenu.js b/www/manager6/dc/CmdMenu.js
> index 87671adb..5bb4d7d1 100644
> --- a/www/manager6/dc/CmdMenu.js
> +++ b/www/manager6/dc/CmdMenu.js
> @@ -117,7 +117,7 @@ Ext.define('PVE.dc.TagCmdMenu', {
>   
>           me.title = `${gettext('Tag')} '${me.tag}'`;
>           if (PVE.ClusterName?.length) {
> -            me.title += ` (${me.nodename})`;
> +            me.title += ` (${PVE.ClusterName})`;
>           }
>   
>           me.extraHandlerArgs = {