From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 89FB7AB4F for ; Fri, 8 Sep 2023 12:53:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 68CBB10870 for ; Fri, 8 Sep 2023 12:53:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 8 Sep 2023 12:53:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 84EBC4355A for ; Fri, 8 Sep 2023 12:53:04 +0200 (CEST) Message-ID: Date: Fri, 8 Sep 2023 12:53:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: Markus Frank , Proxmox VE development discussion References: <20230908104649.123330-1-m.frank@proxmox.com> From: Markus Frank In-Reply-To: <20230908104649.123330-1-m.frank@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.689 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.473 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, qemu.pm] Subject: Re: [pve-devel] [PATCH qemu-sever/novnc/manager/docs v11 0/6] Feature VNC-Clipboard X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2023 10:53:35 -0000 forgot to update novnc-pve -> ignore this v11 series At Fri Sep 08 2023 12:46:43 GMT+0200 (Central European Summer Time), Markus Frank wrote: > overall changes v11: > * renamed vnc-clipboard to clipboard and changed it to a string > > overall changes v9: > * renamed vnc_clipboard to vnc-clipboard > > > qemu-sever: > > changes v10: > * separated "vnc-clipboard return at status/current" to its own patch > * added missing trailing comma > * changed capitalization > > changes v8: > * removed unnecessary conditions > * removed spicedevices variable and changed back to devices > * created is_spice variable > > changes v6: > * added check if vga->type is set to prevent error when using default display > * renamed clipboard to vnc_clipboard > > changes v5: > * removed return of regex check in the assertion-function for the clipboard config > * moved clipboard code into spice-if-block > > changes v4: > * removed duplicate code and created a spicedevices variable to store > spice/vdagent devices. > * clipboard_check_compatibility function > > changes v3: > * added hint to make clearer that the spice guest tools are required for > the noVNC-clipboard > * Checkbox changes to ComboBox when a spice device is selected to make > clear that only one clipboard can be used at a time. > * added 2 test-cases > > changes v2: > * added pci address to virtio-serial-pci > > Markus Frank (3): > enable VNC clipboard parameter in vga_fmt > add vnc-clipboard variable to return at status/current > test cases for clipboard spice & std > > PVE/API2/Qemu.pm | 15 ++++++ > PVE/QemuServer.pm | 66 ++++++++++++++++------- > test/cfg2cmd/VNC-clipboard-spice.conf | 1 + > test/cfg2cmd/VNC-clipboard-spice.conf.cmd | 27 ++++++++++ > test/cfg2cmd/VNC-clipboard-std.conf | 1 + > test/cfg2cmd/VNC-clipboard-std.conf.cmd | 27 ++++++++++ > 6 files changed, 119 insertions(+), 18 deletions(-) > create mode 100644 test/cfg2cmd/VNC-clipboard-spice.conf > create mode 100644 test/cfg2cmd/VNC-clipboard-spice.conf.cmd > create mode 100644 test/cfg2cmd/VNC-clipboard-std.conf > create mode 100644 test/cfg2cmd/VNC-clipboard-std.conf.cmd > > > novnc: > > Markus Frank (1): > add "show clipboard button" patch to series > > .../patches/0019-show-clipboard-button.patch | 30 +++++++++++++++++++ > debian/patches/series | 1 + > 2 files changed, 31 insertions(+) > create mode 100644 debian/patches/0019-show-clipboard-button.patch > > > manager: > > changes v11: > * added hint that SPICE & VNC Clipboard won't work at the same time. > > changes v7: > * fixed the empty Display Bug in VGA options found by Friedrich > (it should be "Default" instead of empty) > > changes v6: > * Changed onGetValues in DisplayEdit to only set the saved vnc_clipboard > variable, so it's possible to reset type and memory to default values > > changes v4: > * moved clipboard option from Display settings in Hardware to Options > > Markus Frank (1): > add clipboard checkbox to VM Options > > www/manager6/qemu/DisplayEdit.js | 8 +++++ > www/manager6/qemu/Options.js | 52 ++++++++++++++++++++++++++++++++ > 2 files changed, 60 insertions(+) > > > docs: > > changes v4: > * rewrote entire Text > * added command example to set clipboard to 1 > > Markus Frank (1): > add VNC clipboard documentation > > qm.adoc | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) >