From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7166592472 for ; Mon, 12 Sep 2022 16:13:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 67FED65FD for ; Mon, 12 Sep 2022 16:12:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 12 Sep 2022 16:12:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A390443370 for ; Mon, 12 Sep 2022 16:12:35 +0200 (CEST) Message-ID: Date: Mon, 12 Sep 2022 16:12:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Thunderbird/105.0 Content-Language: en-GB To: Proxmox VE development discussion , Stefan Hanreich References: <20220912120008.1220711-1-s.hanreich@proxmox.com> <20220912120008.1220711-2-s.hanreich@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220912120008.1220711-2-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -4.101 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH pve-container v2 1/1] fix #4228: add start parameter to rollback endpoint for automatic restarting of CT X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2022 14:13:06 -0000 Am 12/09/2022 um 14:00 schrieb Stefan Hanreich: > Signed-off-by: Stefan Hanreich > --- > src/PVE/API2/LXC/Snapshot.pm | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/src/PVE/API2/LXC/Snapshot.pm b/src/PVE/API2/LXC/Snapshot.pm > index 4be16ad..62adaee 100644 > --- a/src/PVE/API2/LXC/Snapshot.pm > +++ b/src/PVE/API2/LXC/Snapshot.pm > @@ -272,6 +272,11 @@ __PACKAGE__->register_method({ > node => get_standard_option('pve-node'), > vmid => get_standard_option('pve-vmid'), > snapname => get_standard_option('pve-snapshot-name'), > + start => { > + optional => 1, > + type => 'string', why is this a string and not a 'boolean'? We normally also document the default in the schema through, well, the default => X key. > + description => "whether the container should get restarted afterwards", Please try to use somewhat full sentences, that can stand alone and avoids question like "afterward what?", e.g.: "Whether the container should get started after rolling back successfully" > + }, > }, > }, > returns => { > @@ -291,9 +296,16 @@ __PACKAGE__->register_method({ > > my $snapname = extract_param($param, 'snapname'); > > + my $start = extract_param($param, 'start'); do you need to extract (i.e., delete from $param hash) the parameter? Otherwise just use $param->{start} directly below. > + > my $realcmd = sub { > PVE::Cluster::log_msg('info', $authuser, "rollback snapshot LXC $vmid: $snapname"); > PVE::LXC::Config->snapshot_rollback($vmid, $snapname); > + > + if ($start) { > + PVE::Cluster::log_msg('info', $authuser, "start CT $vmid"); why produce a cluster log here? The vm_start already does a syslog and if we'd like to get a cluster log too (or instead of that) it would be an independent patch and done in PVE::API2::LXC::Status's vm_start code (not that I see much need for that) > + PVE::API2::LXC::Status->vm_start({ vmid => $vmid, node => $node }) > + } > }; > > my $worker = sub {