From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 28E691FF1A6 for ; Fri, 5 Dec 2025 16:16:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DA51D4848; Fri, 5 Dec 2025 16:17:04 +0100 (CET) Message-ID: Date: Fri, 5 Dec 2025 16:16:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Dominik Csapak References: <20251205143450.2953331-1-d.csapak@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20251205143450.2953331-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764947743546 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH widget-toolkit] RRDTypeSelector: fix extjs debug mode X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 05.12.25 um 15:34 schrieb Dominik Csapak: > For some reason, using a space separated list of classes in `itemCls` > breaks the extjs debug mode. This is seemingly allowed everywhere else, > so to fix it, simply apply the classes directly to the children > with 'default'. This is what I mentioned off-list a two weeks or so ago, I lost track off it so thx for checking again. > > Signed-off-by: Dominik Csapak > --- > src/form/RRDTypeSelector.js | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/form/RRDTypeSelector.js b/src/form/RRDTypeSelector.js > index bbb5d86..51ae23a 100644 > --- a/src/form/RRDTypeSelector.js > +++ b/src/form/RRDTypeSelector.js > @@ -75,7 +75,9 @@ Ext.define('Proxmox.form.RRDTypeSelector', { > xtype: 'segmentedbutton', > allowMultiple: false, > allowToggle: true, > - itemCls: 'x-btn-default-toolbar-small proxmox-inline-button', > + defautl: { > + cls: 'x-btn-default-toolbar-small proxmox-inline-button', > + }, using an array makes it work too here: itemCls: ['x-btn-default-toolbar-small', 'proxmox-inline-button'], But your variant is probably the slightly nicer one I think. > items: [ > { > text: gettext('Maximum'), _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel