From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D2BB8775E1 for ; Fri, 22 Oct 2021 11:42:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C153A8FB8 for ; Fri, 22 Oct 2021 11:42:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1A6928FA2 for ; Fri, 22 Oct 2021 11:42:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DC08C46939 for ; Fri, 22 Oct 2021 11:42:18 +0200 (CEST) Message-ID: Date: Fri, 22 Oct 2021 11:42:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0 Content-Language: en-GB To: Proxmox VE development discussion , Oguz Bektas References: <20211021143619.1591105-1-o.bektas@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211021143619.1591105-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.184 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cgroup.pm] Subject: [pve-devel] applied: Re: [PATCH common] cgroup: fix default values for change_cpu_quota (cgroup v1) X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Oct 2021 09:42:49 -0000 On 21/10/2021 16:36, Oguz Bektas wrote: > when period is undefined it should be set to 100ms (default value) > > ===== > cpu.cfs_quota_us: the total available run-time within a period (in > microseconds) > cpu.cfs_period_us: the length of a period (in microseconds) > cpu.stat: exports throttling statistics [explained further below] > > The default values are: > cpu.cfs_period_us=100ms > cpu.cfs_quota=-1 > ===== > see [0] > > [0]: https://www.kernel.org/doc/Documentation/scheduler/sched-bwc.txt > > Signed-off-by: Oguz Bektas > --- > src/PVE/CGroup.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks! FYI: I amended the commit message a bit, the subject implied that more than one value was wrong, so I used: "cgroup: cpu quota: fix resetting period length for v1" and linked to the non-legacy, now reStructuredText based version of the docs to a fixed kernel version (I used v5.14 as some docs rendering issues got fixed in that version and content wise it did not change).