From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DF7B96A2D1 for ; Wed, 16 Mar 2022 08:15:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D54FA24670 for ; Wed, 16 Mar 2022 08:15:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3E40B24663 for ; Wed, 16 Mar 2022 08:15:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 102B646C62 for ; Wed, 16 Mar 2022 08:15:58 +0100 (CET) Message-ID: Date: Wed, 16 Mar 2022 08:15:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox VE development discussion , Hannes Laimer References: <20220314092657.48696-1-h.laimer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220314092657.48696-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH-SERIES v3] fix #3903: remove vmid from jobs.cfg on destroy X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 07:15:58 -0000 higher level comment: We cannot do it this way as it adds a cyclic dependency between pve-container <-> pve-manager and qemu-server <-> pve-manager, which is not allowed (such things, besides being ugly, make bootstrapping *a lot* harder, and as I'm most often doing the bootstrap effort I NAK this). pve-manager must only be a perl-module consumer for other repos, never a provider. I mean, it's not like Dominik and I did not predict such things when adding the Jobs stuff in manager, but neither guest-common (there are guets unrelated jobs we want to add like (finally) LDAP sync) nor pve-common (to high up the chain means less access to other modules, e.g., pve-cluster) weren't a really good fitting place then, especially as we had quite the time pressure, so we added all in pve-manager as there we have the least coupling for moving it in the future. I'd actually move the base jobs stuff to pve-cluster (possibly a new binary package) as that's the highest point we can move it and it's not completely wrong.