From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C3FBB1FF163 for <inbox@lore.proxmox.com>; Thu, 5 Dec 2024 14:37:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 02AB81AA31; Thu, 5 Dec 2024 14:37:47 +0100 (CET) Message-ID: <b3b4eb4e-88fe-4dd4-b0d5-5951a89b3d9e@proxmox.com> Date: Thu, 5 Dec 2024 14:37:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Gabriel Goller <g.goller@proxmox.com> References: <20241205102348.216706-1-g.goller@proxmox.com> <20241205102348.216706-2-g.goller@proxmox.com> <a02a2bdb-2632-4448-9c68-4dca4a6b6e2e@proxmox.com> <5vt6likn666v6qmp7vltpjneavrmw2xayxmb63mcycdshubpne@akntfjnletrk> Content-Language: de-AT, en-US From: Lukas Wagner <l.wagner@proxmox.com> In-Reply-To: <5vt6likn666v6qmp7vltpjneavrmw2xayxmb63mcycdshubpne@akntfjnletrk> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2] log: add perlmod logger X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On 2024-12-05 14:17, Gabriel Goller wrote: >> Minor nit: repo in the subject prefix is missing, also the order of patches should probably reversed. > > Happens when you don't use murpp, am I right? :) > >> Seems to work fine, now messages logged by proxmox-notify while being in task context show up >> in the task logs again. Only downside to this approach is that we now also log to stderr >> in regular daemon (non-task) context? I don't think this is an issue tho? > > I think we nearly always call perlmod functions in tasks anyway so it > should be fine. Worst case is you get duplicated errors in the journal > (i.e. stderr routed to journal and normal journal print). > Thinking about notifications, we have - backup jobs -> task context - package-update -> no task - fencing -> no task - storage-replication -> no task IIRC So at least for notifications, the majority does not run in task context. Anyway, afaik we don't redirect stderr to the journal in PVE, so we shouldn't even get any duplicated messages. I think stdout/stderr is only visible if you run pvedaemon/pveproxy in foreground. At least that's how I remember it :D -- - Lukas _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel