From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 27155BA3F8 for ; Tue, 19 Mar 2024 15:58:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F28031C0A for ; Tue, 19 Mar 2024 15:57:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 19 Mar 2024 15:57:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 140B24683E for ; Tue, 19 Mar 2024 15:57:35 +0100 (CET) Message-ID: Date: Tue, 19 Mar 2024 15:57:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Christoph Heiss References: <20240319134851.747097-1-c.heiss@proxmox.com> From: Fiona Ebner In-Reply-To: <20240319134851.747097-1-c.heiss@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH access-control] jobs: realm sync: fix scheduled LDAP syncs not applying attributes correctly X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2024 14:58:07 -0000 Am 19.03.24 um 14:48 schrieb Christoph Heiss: > This was reported by a user in the forum [0]. > > The cause was that the user-* standard options were not registered when > the sync was called from the scheduler, resulting in the following > error: > > pvescheduler[2849]: skipping attribute mapping 'cn'->'comment' for user 'test@samba0' - no such standard option 'user-comment' > > Fix this by simply importing the PVE::API2::User module, thus ensuring > the options get registered. > > [0] https://forum.proxmox.com/threads/ldap-integration-comment-email-first-name-lastname.143490/ > > Signed-off-by: Christoph Heiss Fixes: cb93636 ("LDAP sync: improve validation of synced attributes") Reviewed-by: Fiona Ebner Tested-by: Fiona Ebner Thank you for the fix! The schema for the user- properties could also be moved somewhere that can be accessed by both API2::User module and Auth::LDAP module and included there directly. That would be more future-proof, but as a quick fix, this is fine too.