From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C23D820EC91 for ; Tue, 30 Apr 2024 11:45:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D561302CD; Tue, 30 Apr 2024 11:45:43 +0200 (CEST) Message-ID: Date: Tue, 30 Apr 2024 11:45:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Fiona Ebner , Wolfgang Bumiller References: <20240430075343.39367-1-w.bumiller@proxmox.com> <0c6b8981-11cf-4f5e-8567-25c0f8e25ffe@proxmox.com> <4qssgd7wmmrlahcxe5j6tqmfonvv3a4ye3tnebrkyegmk77n55@3gxmtkrgghip> <21017c63-9c3c-48ea-8152-df5c66fa1a0c@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <21017c63-9c3c-48ea-8152-df5c66fa1a0c@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage 1/2] don't bail on whitespaces in backing devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 4/30/24 11:13, Fiona Ebner wrote: > Am 30.04.24 um 10:38 schrieb Wolfgang Bumiller: >> - technically users could add a disk with a "bad" parent to a storage >> *manually*, but given the list_images mentioned above, I'd argue the >> situation isn't really getting worse, as values that *do* match `\S+` >> don't necessarily match the regexes used *later* on the parent >> *anyway*... >> > > CC Dominik > > Thinking in the context of uploading OVAs (or uploading disk images), I > guess we need a check against arbitrary backing file paths in uploaded > qcow2/vmdk images (or do we already have that)? > good point, we currently don't, but it shouldn't be hard to add that check before importing/after uploading... i'll look into that _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel