From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 4A3B21FF142 for ; Fri, 03 Jul 2026 08:33:48 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 133D02136C; Fri, 03 Jul 2026 08:33:47 +0200 (CEST) Message-ID: Date: Fri, 3 Jul 2026 08:33:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH guest-common/manager/qemu-server v3 0/3] fix #5032: add guest time sync via QGA To: Maximiliano Sandoval References: <20260702103201.164567-1-j.klocker@proxmox.com> Content-Language: en-US From: Jakob Klocker In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783060384298 X-SPAM-LEVEL: Spam detection results: 1 AWL 0.910 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HFW4AB2RREMOYXTCTN2FBDTUVDWWC67X X-Message-ID-Hash: HFW4AB2RREMOYXTCTN2FBDTUVDWWC67X X-MailFrom: j.klocker@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the feedback! I'll adjust the error message to match`guest_fs_freeze_applicable` in a v4. On 7/2/26 5:14 PM, Maximiliano Sandoval wrote: > [snip] > @jakob: One thing that would be nice to improve is the error message > when the guest agent is not enabled inside the guest. Perhaps it is > possible to print a message saying that we skipped the guest-set-time > command because the guest agent was not running, similarly to what we do > for the guest-fsfreeze-freeze calls. However, it might be undesirable to > add yet another guest agent call just to check if it is there though. > > Tested-by: Maximiliano Sandoval >