From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 8177D1FF170
	for <inbox@lore.proxmox.com>; Tue, 19 Nov 2024 11:47:25 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id AE0D91FE6F;
	Tue, 19 Nov 2024 11:47:31 +0100 (CET)
Message-ID: <b1e7f743-77f8-45bf-a94a-67c5b8306a9e@proxmox.com>
Date: Tue, 19 Nov 2024 11:46:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: pve-devel@lists.proxmox.com
References: <20241119104509.77381-1-m.limbeck@proxmox.com>
Content-Language: en-US
From: Mira Limbeck <m.limbeck@proxmox.com>
In-Reply-To: <20241119104509.77381-1-m.limbeck@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.336 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH installer] warn if maxvz is set and <= 4 GiB
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On 11/19/24 11:45, Mira Limbeck wrote:
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
>  Proxmox/Install.pm | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
> index c64e1d4..da8fb55 100644
> --- a/Proxmox/Install.pm
> +++ b/Proxmox/Install.pm
> @@ -555,6 +555,10 @@ sub create_lvm_volumes {
>  	my $maxvz = Proxmox::Install::Config::get_maxvz();
>  	if ($iso_env->{product} eq 'pve' && !defined($maxvz)) {
>  	    Proxmox::UI::message("Skipping auto-creation of LVM thinpool for guest data due to low space.");
> +	} elsif ($iso_env->{product} eq 'pve') {
> +	    Proxmox::UI::message(
> +		"Skipping auto-creation of LVM thinpool for guest data, Maximum data volume size set too low."
> +	    );
>  	}
>  	$datadev = undef;
>      }

Sent it a bit too soon, maybe we want to check if $maxvz is 0 and don't
warn in that case?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel