From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EE40F1FF13B for ; Wed, 06 May 2026 13:54:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3B4361EA5C; Wed, 6 May 2026 13:54:58 +0200 (CEST) Message-ID: Date: Wed, 6 May 2026 13:54:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH manager] certificate: make sure that any new certificate and key match To: Shannon Sterz , pve-devel@lists.proxmox.com References: <20260506110452.166057-1-s.sterz@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260506110452.166057-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778068353331 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GFQWONTM32MQ4YJDYQ7OXCRAXI7IWWUS X-Message-ID-Hash: GFQWONTM32MQ4YJDYQ7OXCRAXI7IWWUS X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 06.05.26 um 13:03 schrieb Shannon Sterz: > previously it was possible to upload and set a key and certificate > combination, that did not match each other. this lead to confusing > errors as pveproxy would seemingly start, but not actually serve any > http connections. in a cluster context this leads to "broken pipe" > errors when connecting to such a misconfigured node. since this is > rather confusing, verify that a key and certificate can actually be > used before setting them as the current certificates by loading them > into a TLS context. > > Signed-off-by: Shannon Sterz > --- > > Notes: > this came up in the enterprise support and caused quite a bit of > confusion. nice UX polishing. > > PVE/CertHelpers.pm | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/PVE/CertHelpers.pm b/PVE/CertHelpers.pm > index ee945827f..2fc241c24 100644 > --- a/PVE/CertHelpers.pm > +++ b/PVE/CertHelpers.pm > @@ -7,6 +7,8 @@ use PVE::Certificate; > use PVE::JSONSchema; > use PVE::Tools; > > +use Net::SSLeay; > + > my $account_prefix = '/etc/pve/priv/acme'; > > PVE::JSONSchema::register_standard_option( > @@ -81,6 +83,31 @@ sub set_cert_files { > PVE::Tools::file_set_contents($cert_path, $cert); > PVE::Tools::file_set_contents($key_path, $key) if $key; > $info = PVE::Certificate::get_certificate_info($cert_path); > + > + if (my $method = Net::SSLeay::TLS_method()) { > + my $ctx = Net::SSLeay::CTX_new_with_method($method); > + > + eval { > + Net::SSLeay::CTX_use_certificate_chain_file($ctx, $cert_path) > + or die "could not load certificate (chain)\n"; > + Net::SSLeay::CTX_use_PrivateKey_file( > + $ctx, > + $key_path, > + Net::SSLeay::FILETYPE_PEM(), > + ) or die "key does not match the certificate (chain)\n"; Should we include the error stack [0] here too in these calls? Might make debugging even easier, and as the user provided these certs, (or ACME generated them), we cannot really leak anything with doing that I think. [0]: https://metacpan.org/pod/Net::SSLeay#Error-handling-functions > + }; > + > + my $err = $@; > + > + if ($err) { > + # clean up invalid certificate and key > + unlink $cert_path; error handling would be nice here: unlink $cert_path or $!{ENOENT} or warn "failed to clean-up $cert_path - $!\n"; > + unlink $key_path; same here> + die $err; > + } > + } else { > + warn "no TLS method to verify certificate and key match, continuing anyway\n"; > + } > }; > my $err = $@; >