From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 383B01FF0AB for ; Mon, 07 Sep 2026 10:42:56 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3DACB21545; Mon, 07 Sep 2026 10:42:51 +0200 (CEST) Message-ID: Date: Mon, 7 Sep 2026 10:42:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-xtermjs 0/3] xterm.js: fix obstructed start button To: Dominik Csapak , pve-devel@lists.proxmox.com References: <20260902074338.914500-1-d.csapak@proxmox.com> Content-Language: en-US From: Filip Schauer In-Reply-To: <20260902074338.914500-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788770558810 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.711 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YNEWHVJYZHUD52MRS4AKW2YT2TS35HI5 X-Message-ID-Hash: YNEWHVJYZHUD52MRS4AKW2YT2TS35HI5 X-MailFrom: f.schauer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 02/09/2026 09:43, Dominik Csapak wrote: > The first two patches are just formatting cleanup to make development > easier when using proxmox-biome as LSP and the third patch is the actual > fix. > > Not sure how this was broken, I tested this with old chrome/firefox > versions and our older xterm.js packages and could still reproduce. Then > tested on a PVE 8.4 install and it also happened. (Though with older > xterm.js releases it was not as noticable since the default > background-color changed in the last few releases) > > So my current guess is that either something unrelated changed which > has an influence on this (desktop environments, etc.) or this was simply > broken since a long time. Can confirm that xterm.js is no longer displayed on a stopped container, which fixes the start button obstruction on consoles with a small height. Tested-by: Filip Schauer