From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2E2069AE0D for ; Mon, 16 Oct 2023 13:43:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 10CB5172C7 for ; Mon, 16 Oct 2023 13:43:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 16 Oct 2023 13:43:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DD95041042 for ; Mon, 16 Oct 2023 13:43:12 +0200 (CEST) Message-ID: Date: Mon, 16 Oct 2023 13:43:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Filip Schauer References: <20231013135006.96272-1-f.schauer@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20231013135006.96272-1-f.schauer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.087 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] Fix races with suspended VMs that can wake up X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2023 11:43:16 -0000 I'd add a bit to the commit message, but changes look good to me: Am 13.10.23 um 15:50 schrieb Filip Schauer: > Fix races with ACPI-suspended VMs which could wake up during migration > or during a suspend-mode backup. > > Revert prevention, of ACPI-suspended VMs automatically resuming after > migration, introduced by 7ba974a6828d. The commit introduced a potential > problem that causes a suspended VM that wakes up during migration to > remain paused after the migration finishes. > This can be fixed once QEMU preserves the 'suspended' runstate during migration (current patch on the qemu-devel list [0]) by checking for the 'suspended' runstate on the target after migration. > Furthermore the commit increased the race window during the preparation > of a suspend-mode backup, when a suspended VM wakes up between the > vm_is_paused check in PVE::VZDump::QemuServer::prepare and > PVE::VZDump::QemuServer::qga_fs_freeze. This causes the code to skip > fs-freeze even if the VM has woken up, potentially leaving the file > system in an inconsistent state. > > To prevent this, do not treat the suspended runstate as paused when > migrating or archiving a VM. > [0]: https://lists.nongnu.org/archive/html/qemu-devel/2023-08/msg05260.html > Signed-off-by: Filip Schauer Reviewed-by: Fiona Ebner