From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6C38D68EDF for ; Tue, 22 Mar 2022 09:49:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 631D61B7C7 for ; Tue, 22 Mar 2022 09:48:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C22C51B7BB for ; Tue, 22 Mar 2022 09:48:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9B65F46F41 for ; Tue, 22 Mar 2022 09:48:52 +0100 (CET) Message-ID: Date: Tue, 22 Mar 2022 09:48:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: pve-devel@lists.proxmox.com, Matthias Heiserer References: <20220318135226.2360890-1-m.heiserer@proxmox.com> <20220318135226.2360890-6-m.heiserer@proxmox.com> From: Fabian Ebner In-Reply-To: <20220318135226.2360890-6-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.118 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager 5/5 v2] Storage ContentView: Remove dead code X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2022 08:49:23 -0000 Am 18.03.22 um 14:52 schrieb Matthias Heiserer: > These lines were only used by grid/BackupView, which gets deleted in > this series. > > > Signed-off-by: Matthias Heiserer > --- > www/manager6/storage/ContentView.js | 22 ++-------------------- > 1 file changed, 2 insertions(+), 20 deletions(-) > > diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js > index 2874b71e..cb22ab4d 100644 > --- a/www/manager6/storage/ContentView.js > +++ b/www/manager6/storage/ContentView.js > @@ -155,20 +155,6 @@ Ext.define('PVE.storage.ContentView', { > renderer: PVE.Utils.render_storage_content, > dataIndex: 'text', > }, > - 'notes': { > - header: gettext('Notes'), > - flex: 1, > - renderer: Ext.htmlEncode, > - dataIndex: 'notes', > - }, > - 'protected': { > - header: ``, > - tooltip: gettext('Protected'), > - width: 30, > - renderer: v => v ? `` : '', > - sorter: (a, b) => (b.data.protected || 0) - (a.data.protected || 0), > - dataIndex: 'protected', > - }, > 'date': { > header: gettext('Date'), > width: 150, > @@ -194,10 +180,6 @@ Ext.define('PVE.storage.ContentView', { > delete availableColumns[key]; > } >From a quick look, the showColumns special casing right above here seems to also be unnecessary now. > }); > - > - if (me.extraColumns && typeof me.extraColumns === 'object') { > - Object.assign(availableColumns, me.extraColumns); > - } > const columns = Object.values(availableColumns); > > Ext.apply(me, { > @@ -216,8 +198,8 @@ Ext.define('PVE.storage.ContentView', { > Ext.define('pve-storage-content', { > extend: 'Ext.data.Model', > fields: [ > - 'volid', 'content', 'format', 'size', 'used', 'vmid', > - 'channel', 'id', 'lun', 'notes', 'verification', > + 'volid', 'content', 'format', 'size', 'used', > + 'channel', 'id', 'lun', > { > name: 'text', > convert: function(value, record) {