From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CAA4F1FF179 for ; Wed, 1 Oct 2025 09:23:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2D8B81804F; Wed, 1 Oct 2025 09:23:47 +0200 (CEST) Message-ID: Date: Wed, 1 Oct 2025 09:23:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Stefan Hanreich References: <20250925122142.228719-1-s.hanreich@proxmox.com> <20250925122142.228719-2-s.hanreich@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20250925122142.228719-2-s.hanreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759303371794 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [vm.rs] Subject: Re: [pve-devel] [PATCH proxmox-ve-rs v2 1/1] config: guest: store network devices in BTreeMap X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 9/25/25 14:22, Stefan Hanreich wrote: > Enables iterating over the network devices in order, without > performing any additional sorting at the call sites. This makes the > output in proxmox-firewall stable, which is useful for test cases as > well as for comparing the output of different proxmox-firewall runs. > Are we actually explicitly sorting anywhere? I didn't really find any places. If there should be, we can drop those. Nonetheless this makes a lot if sense. > Signed-off-by: Stefan Hanreich > --- > proxmox-ve-config/src/guest/vm.rs | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/proxmox-ve-config/src/guest/vm.rs b/proxmox-ve-config/src/guest/vm.rs > index cc97781..baff1b8 100644 > --- a/proxmox-ve-config/src/guest/vm.rs > +++ b/proxmox-ve-config/src/guest/vm.rs > @@ -1,4 +1,4 @@ > -use std::collections::HashMap; > +use std::collections::BTreeMap; > use std::io; > use std::str::FromStr; > > @@ -278,7 +278,7 @@ impl FromStr for NetworkDevice { > #[derive(Debug, Default)] > #[cfg_attr(test, derive(Eq, PartialEq))] > pub struct NetworkConfig { > - network_devices: HashMap, > + network_devices: BTreeMap, > } > > impl NetworkConfig { > @@ -300,12 +300,12 @@ impl NetworkConfig { > bail!("No index found in net key string: {key}") > } > > - pub fn network_devices(&self) -> &HashMap { > + pub fn network_devices(&self) -> &BTreeMap { > &self.network_devices > } > > pub fn parse(input: R) -> Result { > - let mut network_devices = HashMap::new(); > + let mut network_devices = BTreeMap::new(); > > for line in input.lines() { > let line = line?; _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel