From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 4B3CF1FF13F
	for <inbox@lore.proxmox.com>; Thu, 29 Jan 2026 18:39:02 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 33787DD05;
	Thu, 29 Jan 2026 18:39:25 +0100 (CET)
Message-ID: <b0e4fcd6-1c9a-43c1-a0c3-0dc517f107f5@proxmox.com>
Date: Thu, 29 Jan 2026 18:38:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [pve-devel] [PATCH pve-network 1/2] fix #7077: Improve error
 messages for ID length mismatch
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
References: <20260121103407.187187-1-a.bied-charreton@proxmox.com>
 <20260121103407.187187-5-a.bied-charreton@proxmox.com>
Content-Language: en-US
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20260121103407.187187-5-a.bied-charreton@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1769708262800
X-SPAM-LEVEL: Spam detection results:  0
	AWL                    -0.021 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	RCVD_IN_VALIDITY_CERTIFIED_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_RPBL_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_SAFE_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: VVNUUHDZTJKD7TNGZYMQQELREXWXB6QL
X-Message-ID-Hash: VVNUUHDZTJKD7TNGZYMQQELREXWXB6QL
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 21.01.26 um 11:34 schrieb Arthur Bied-Charreton:
> Add explicit length checks to ID validation functions to provide clearer
> error messages in case of length mismatches

A few of these checks might be also done by setting the "maxLength" and/or the
"minLength" property in the matching "register_standard_option" schema definition.
Could you check that? Would be IMO better to reuse the schema capabillities, and
that way, this limits would be also visible in the api schema directly.