From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3E6391FF2AD for ; Thu, 4 Jul 2024 11:05:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 28E521ED3E; Thu, 4 Jul 2024 11:05:41 +0200 (CEST) Date: Thu, 4 Jul 2024 11:05:07 +0200 From: Christoph Heiss To: Max Carrara Message-ID: References: <20240613115318.842583-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer 0/4] tui: make disk options view tabbed on small screens X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue, Jul 02, 2024 at 06:49:12PM GMT, Max Carrara wrote: > On Thu Jun 13, 2024 at 1:53 PM CEST, Christoph Heiss wrote: > > [..] > > Pretty neat! I like this a lot. See my entire feedback below. > > Leaving these here already so they don't get lost ;) > > Reviewed-by: Max Carrara > Tested-by: Max Carrara > Thanks for the review! [..] > Testing > ------- > > * tty size: 60x15 > - tabs work as intended, but the actual contents of the tabs get lost > for ZFS and BTRFS configurations, because there's not enough > vertical space > - it's (unsurprisingly) still possible to navigate through those > options, they're just not visible > - my suggestion would be to add some kind of scrolling view here, > though I'm not sure if we're aiming to support ttys that are *this* > small > > * tty size: 60x20 > - same as above, except that the first (four) configuration options > in the advanced disk config tab are displayed, the other ones are > still lost Well, 80x24 is basically the minimum size I'd reasonable support. It's the resolution specified by the VT10x, so I would say it's safe to assume that every video output supports at _least_ that. It's also what's used for serial output. See also e.g. commit 3facbe51c [0] or the VT100 technical manual [1] some more in-depth information. And since the target is pretty defined for this (always fullscreen on some video output, not some resizable graphical terminal window or such), so I think supporting anything less would be a lot of work for pretty much no return. > > * tty size: 80x24 > - works pretty great, as there now is enough vertical space to display > everything > - haven't tested with multiple disks, but if a user wanted to e.g. > use ZFS with *a lot* of disks, there's still a risk that they might > run out of vertical space in the disk selection tab The disk view is scrollable and should scroll as needed. Tested this with ~12 disks. > > * tty size: 81x24 > - feels awkward (as it does without this series :P) because the right > column in the advanced disk config tab gets squeezed (squoze?) too > much > - as you suggested above, the tab view could therefore IMO be made the > default in general, it just looks really neat overall; I personally > prefer it quite a lot over the old one Yeah, that's what I thought, but I wasn't sure. It would also match the GTK installer in that regard. The side-by-side is quite nice on wide screens though, but no hard feelings :^) [0] https://git.proxmox.com/?p=pve-installer.git;a=commitdiff;h=3facbe51c [1] https://vt100.net/dec/ek-vt100-tm-002.pdf (page 21, "Format") _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel