From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 4DEF21FF0DA for ; Thu, 19 Nov 2026 16:33:40 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 500F3216C0; Thu, 19 Nov 2026 16:33:38 +0100 (CET) Date: Thu, 19 Nov 2026 16:33:33 +0100 From: Gabriel Goller To: Stefan Hanreich Subject: Re: [PATCH common/manager/network/proxmox{-ve-rs,-perl-rs,-widget-toolkit} v3 00/32] SDN VRF support Message-ID: References: <20261116161154.343743-1-g.goller@proxmox.com> <92739a0c-b3b7-4dcf-b20c-51714853a31e@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <92739a0c-b3b7-4dcf-b20c-51714853a31e@proxmox.com> User-Agent: NeoMutt/20260616 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795102414602 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.245 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IB4MMJ5DQITMYO6NTMUPNFGPNNRG6WPZ X-Message-ID-Hash: IB4MMJ5DQITMYO6NTMUPNFGPNNRG6WPZ X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 18.11.2026 19:27, Stefan Hanreich wrote: > haven't looked at the UI patches yet, tried to look at the design, didn't get > to do a lot of testing so all of this is judging from the code basically: > > > nexthop-vrf is really sketchy imo, as it allows a user with SDN.Allocate on a > simple zone to route traffic into *any* VRF. At the minimum we should require > Sys.Modify for that (as already discussed off-list). > We could lessen that restriction in the future to allow jumping into VRFs of > SDN entities where the user has permissions for (i.e. I can jump into vrf_X > if I have SDN.Use on X) > > staticd validates iface and only allows routes for interfaces that are in the > VRF, which is kinda nice for now since it saves us here but makes creating > specific routes kinda annoying for interfaces outside the VRF. Also, we're > relying on staticd behavior for security here. > > I think those could be solved by just requiring Sys.Modify for static > routes in general. We can always lessen it. > > > SNAT still has quite a few problems (see the patch). We should remove it > and solve them in a follow-up. Also, even without SNAT we need to set CT > zones on simple zones for all traffic in the firewall daemons. We'd have > to think a bit about possible implications of this that I haven't thought > of. > > > We should not create null0 routes for simple zones with a dedicated VRF > in EVPN. Done. > DHCP implementation looks generally fine, but imo we'd need to expose > the DNS server option - as otherwise dnsmasq hands out the system default > DNS server which is probably not reachable inside a simple zone with custom > VRF. This feature certainly deserves some practical testing tho. Also done, existed already, just exposed in ui.