From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 12F851FF0DA for ; Thu, 19 Nov 2026 16:04:06 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5A01B216DD; Thu, 19 Nov 2026 16:04:05 +0100 (CET) Date: Thu, 19 Nov 2026 15:53:53 +0100 From: Gabriel Goller To: Stefan Hanreich Subject: Re: [PATCH pve-network v3 21/32] sdn: simple: support static routes in zone routing tables Message-ID: References: <20261116161154.343743-1-g.goller@proxmox.com> <20261116161154.343743-22-g.goller@proxmox.com> <7c5c0d40-e12e-45ab-b6a3-eecfffb2c4f3@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7c5c0d40-e12e-45ab-b6a3-eecfffb2c4f3@proxmox.com> User-Agent: NeoMutt/20260616 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795100035057 X-SPAM-LEVEL: Spam detection results: 0 AWL -2.269 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_DBL_SPAM 5 Contains a spam URL listed in the Spamhaus DBL blocklist [sdn.pm] Message-ID-Hash: X4WOSQ4YDTZZSVDOWFRJJTHCX4S3XEOT X-Message-ID-Hash: X4WOSQ4YDTZZSVDOWFRJJTHCX4S3XEOT X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 18.11.2026 17:49, Stefan Hanreich wrote: > On 11/16/26 5:16 PM, Gabriel Goller wrote: > > Allow simple zones to reach outside networks through static routes, > > without needing a fabric. Routes use the zone's dedicated VRF, or the > > default routing table if dedicated-vrf is disabled. > > > > Support IPv4 and IPv6 routes, including default routes, with a gateway > > or an outgoing interface. nexthop-vrf allows a gateway in another VRF, > > e.g. the default VRF, without moving the uplink into the zone. > > > > Routes are managed by FRR, so zones with static routes need FRR even > > without a controller or fabric. This requires the matching pve-rs > > support for route validation and FRR config generation. > > > > Signed-off-by: Gabriel Goller > > --- > > src/PVE/API2/Network/SDN/Zones.pm | 9 ++ > > src/PVE/Network/SDN.pm | 22 ++- > > src/PVE/Network/SDN/Zones/Plugin.pm | 55 +++++++ > > src/PVE/Network/SDN/Zones/SimplePlugin.pm | 1 + > > src/test/Makefile | 5 +- > > src/test/run_test_static_routes.pl | 178 ++++++++++++++++++++++ > > 6 files changed, 266 insertions(+), 4 deletions(-) > > create mode 100644 src/test/run_test_static_routes.pl > > > > diff --git a/src/PVE/API2/Network/SDN/Zones.pm b/src/PVE/API2/Network/SDN/Zones.pm > > index e4f4b174466e..8df1bf8527fd 100644 > > --- a/src/PVE/API2/Network/SDN/Zones.pm > > +++ b/src/PVE/API2/Network/SDN/Zones.pm > > @@ -68,6 +68,15 @@ my $ZONE_PROPERTIES = { > > optional => 1, > > description => 'Create a dedicated VRF for a simple zone.', > > }, > > + route => { > > + type => 'array', > > + optional => 1, > > + description => 'Static routes in the zone routing table. Simple zone only.', > > + items => { > > + type => 'string', > > + format => 'pve-sdn-static-route', > > + }, > > + }, > > 'rt-import' => { > > type => 'string', > > optional => 1, > > diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm > > index 9373ec3035fa..626fe7387f54 100644 > > --- a/src/PVE/Network/SDN.pm > > +++ b/src/PVE/Network/SDN.pm > > @@ -17,6 +17,7 @@ use PVE::RESTEnvironment qw(log_warn); > > use PVE::RPCEnvironment; > > use PVE::Tools qw(file_get_contents file_set_contents extract_param dir_glob_regex run_command); > > > > +use PVE::RS::SDN; > > use PVE::RS::SDN::Fabrics; > > > > use PVE::Network::SDN::Vnets; > > @@ -130,10 +131,19 @@ sub running_config_has_frr { > > my $fabrics = $running_config->{fabrics}->{ids} // {}; > > my $route_maps = $running_config->{'route-maps'}->{ids} // {}; > > my $prefix_lists = $running_config->{'prefix-lists'}->{ids} // {}; > > + my $zones = $running_config->{zones}->{ids} // {}; > > + my $zone_routes = > > + grep { $_->{type} eq 'simple' && scalar(@{ $_->{route} // [] }) } values %$zones; > > > > my $local_frr_config = PVE::Network::SDN::Frr::local_frr_config_exists(); > > > > - return %$controllers || %$fabrics || %$route_maps || %$prefix_lists || $local_frr_config; > > + return > > + %$controllers > > + || %$fabrics > > + || %$route_maps > > + || %$prefix_lists > > + || $zone_routes > > + || $local_frr_config; > > } > > > > sub pending_config { > > @@ -563,11 +573,14 @@ sub generate_frr_raw_config { > > > > my $frr_config = {}; > > > > + my $nodename = PVE::INotify::nodename(); > > + > > PVE::Network::SDN::Controllers::generate_frr_config($frr_config, $running_config); > > + my $routes = > > + PVE::RS::SDN::get_zone_routes($running_config->{zones} // { ids => {} }, $nodename); > > + push @{ $frr_config->{frr}->{ip_routes} }, @$routes; > > so static routes in simple zones are handled by staticd? Seems a bit odd at least. > What happens if there's only a simple zone with static routes? Is there a better > way? So the choice here was between staticd (frr) and ifupdown2 post-up ip route add... I went with staticd because ipfudown2 post-up is tricky to remove the routes again and I thought i'd be nice to redistribute static. Also we already have the template system in place which makes it quite easy to generate frr config (staticd always enabled as well). > > > PVE::Network::SDN::Frr::append_local_config($frr_config); > > > > - my $nodename = PVE::INotify::nodename(); > > - > > return PVE::RS::SDN::get_frr_raw_config( > > $frr_config->{'frr'}, > > $prefix_list_config, > > @@ -619,6 +632,9 @@ sub generate_dhcp_config { > > sub encode_value { > > my ($type, $key, $value) = @_; > > > > + # Route strings contain commas themselves, so preserve array element boundaries. > > + return join("\n", sort @$value) if $key eq 'route' && ref($value) eq 'ARRAY'; > > + > > if ( > > $key eq 'nodes' > > || $key eq 'exitnodes' > > diff --git a/src/PVE/Network/SDN/Zones/Plugin.pm b/src/PVE/Network/SDN/Zones/Plugin.pm > > index dc8f19cb6587..a3863bc9818c 100644 > > --- a/src/PVE/Network/SDN/Zones/Plugin.pm > > +++ b/src/PVE/Network/SDN/Zones/Plugin.pm > > @@ -8,6 +8,7 @@ use Net::IP qw(ip_get_version); > > use PVE::JSONSchema; > > use PVE::Cluster; > > use PVE::Network; > > +use PVE::RS::SDN; > > > > use PVE::JSONSchema qw(get_standard_option); > > use base qw(PVE::SectionConfig); > > @@ -29,6 +30,50 @@ PVE::JSONSchema::register_standard_option( > > }, > > ); > > > > +my $static_route_fmt = { > > + prefix => { > > + type => 'string', > > + description => 'Destination prefix in CIDR notation, including default routes.', > > add a format here Used FullRangeCIDR. (Moved out to a new module Formats.pm -- wanted to move it to pve-common, but that requires a synchronous bump, otherwise register_format dies if it's duplicate...). > > + }, > > + via => { > > + type => 'string', > > + format => 'ip', > > + optional => 1, > > + description => 'Next-hop IP address. IPv6 link-local addresses require an interface.', > > + }, > > + iface => { > > + type => 'string', > > + optional => 1, > > + description => 'Outgoing interface. At least one of via or iface is required.', > > add a format here Done > > + }, > > + distance => { > > + type => 'integer', > > + minimum => 1, > > + maximum => 255, > > + optional => 1, > > + description => 'Administrative distance.', > > + }, > > + 'nexthop-vrf' => { > > + type => 'string', > > + optional => 1, > > + description => 'VRF of the next hop, or default for the default routing table.', > > add a format here Removed nexthop-vrf completely.