From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 13AC71FF0C0 for ; Wed, 18 Nov 2026 18:26:25 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 38FD1216E1; Wed, 18 Nov 2026 18:26:24 +0100 (CET) Date: Wed, 18 Nov 2026 18:26:18 +0100 From: Gabriel Goller To: Stefan Hanreich Subject: Re: [PATCH proxmox-ve-rs v3 04/32] sdn: generate fabric routing configuration in zone VRFs Message-ID: References: <20261116161154.343743-1-g.goller@proxmox.com> <20261116161154.343743-5-g.goller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20260616 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795022779232 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.238 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 35AIROLGKTZEW3EPKDLNTMJLKTV4DLN7 X-Message-ID-Hash: 35AIROLGKTZEW3EPKDLNTMJLKTV4DLN7 X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 18.11.2026 15:53, Stefan Hanreich wrote: > On 11/16/26 5:12 PM, Gabriel Goller wrote: > > Map a fabric zone to the corresponding vrf_ FRR instance. Generate > > OSPF routers and interfaces in that VRF, and store BGP routers under the > > same VRF name. Keep fabrics without a zone in the default routing table. > > > > Collect OSPF redistribution rules on the router for the selected VRF so > > that several fabrics in one VRF contribute to the same OSPF instance. > > should we just disallow multiple fabrics in the same zone (except default) > for now? Save us a lot of hassle and complexity, and could be introduced > later if so desired? Hmm I don't we think we can remove a lot of code by disallowing that... Most of the mechanics already exist because we allow multiple fabrics in the default vrf. We just key some stuff by vrf as well. The only change here is that we merge together all the redistributions for all the ospf fabrics in a vrf. This currently doesn't work on master with multiple ospf fabrics on the default vrf -- so we'd have to fix that anyway.