From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 89B601FF0C0 for ; Wed, 18 Nov 2026 17:21:46 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 029D021753; Wed, 18 Nov 2026 17:21:46 +0100 (CET) Date: Wed, 18 Nov 2026 17:21:40 +0100 From: Gabriel Goller To: Stefan Hanreich Subject: Re: [PATCH proxmox-ve-rs v3 02/32] frr: add VRF-aware OSPF rendering Message-ID: References: <20261116161154.343743-1-g.goller@proxmox.com> <20261116161154.343743-3-g.goller@proxmox.com> <369bf097-711d-4e1c-bee0-70d9a64d6930@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <369bf097-711d-4e1c-bee0-70d9a64d6930@proxmox.com> User-Agent: NeoMutt/20260616 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795018901713 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.240 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: C4HH7D4HVDPF3D2MXEXJMJJVKW6D7VH7 X-Message-ID-Hash: C4HH7D4HVDPF3D2MXEXJMJJVKW6D7VH7 X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 18.11.2026 15:41, Stefan Hanreich wrote: > On 11/16/26 5:12 PM, Gabriel Goller wrote: > > [snip] > > diff --git a/proxmox-frr/src/ser/mod.rs b/proxmox-frr/src/ser/mod.rs > > index 0f2b52138cf3..cd3025213fb9 100644 > > --- a/proxmox-frr/src/ser/mod.rs > > +++ b/proxmox-frr/src/ser/mod.rs > > @@ -135,6 +135,8 @@ pub struct Interface { > > pub addresses_v4: Vec, > > #[serde(default)] > > pub addresses_v6: Vec, > > + #[serde(default)] > > + pub vrf: Option, > > would it be better to add this to the concrete interface types that actually support it? Done, added it to OspfInterface. > > > > #[serde(flatten)] > > pub properties: T, > > @@ -144,6 +146,7 @@ impl From for Interface > Interface { > > addresses_v4: Vec::new(), > > addresses_v6: Vec::new(), > > + vrf: None, > > instead of setting it to None for protocols where it isn't supported? Makes sense. > > properties: value, > > } > > } > > @@ -154,6 +157,7 @@ impl From for Interface { > > Interface { > > addresses_v4: Vec::new(), > > addresses_v6: Vec::new(), > > + vrf: None, > > properties: value, > > } > > } > > @@ -248,6 +252,8 @@ pub struct OspfFrrConfig { > > #[serde(default)] > > pub router: Option, > > #[serde(default)] > > + pub vrf_router: BTreeMap, > > can we handle this the same as in BGP where the default VRF is just an entry in the map? Also done. > > + #[serde(default)] > > pub interfaces: BTreeMap>, > > } Thanks for the review!