From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 62B5F1FF0BC for ; Thu, 15 Oct 2026 16:49:24 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D9B3C21488; Thu, 15 Oct 2026 16:49:21 +0200 (CEST) Date: Thu, 15 Oct 2026 16:49:16 +0200 From: Gabriel Goller To: Christoph Heiss Subject: Re: [PATCH ifupdown2] fix #8117: backport upstream fix for unavailable bond slaves Message-ID: References: <20261008102322.95273-1-g.goller@proxmox.com> <26eeb088-76f6-4a17-9d9c-2ae3fb13310f@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <26eeb088-76f6-4a17-9d9c-2ae3fb13310f@proxmox.com> User-Agent: NeoMutt/20260504 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792075757648 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.299 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OXB5AYOIV2ZQVF4CIXDZ57F5VSSJIDEA X-Message-ID-Hash: OXB5AYOIV2ZQVF4CIXDZ57F5VSSJIDEA X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 15.10.2026 16:43, Christoph Heiss wrote: > Thanks for tackling this! > > On 10/8/26 12:23, Gabriel Goller wrote: > > A missing slave at boot can abort bond setup before available slaves are > > enslaved, leaving the bond broken. Backport upstream PR #355 to continue > > setup after single slave failures. > > > > Upstream-Link: https://github.com/CumulusNetworks/ifupdown2/pull/355 > > Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=8117 > > > > Signed-off-by: Gabriel Goller > > Tested this with a similar setup to [0], just with `bond-slaves` set to: > > bond-slaves doesnotexist enp6s20.1 enp6s21.1 > > Please consider this: > > Tested-by: Christoph Heiss > > [0] > https://lore.proxmox.com/pve-devel/DM5AYOQZLL1E.2J6DHNGY4O0N4@proxmox.com/ > > [..] > > > +diff --git a/tests/unit/test_bond.py b/tests/unit/test_bond.py > > +new file mode 100644 > > +index 00000000..01fab468 > > +--- /dev/null > > ++++ b/tests/unit/test_bond.py > > +@@ -0,0 +1,103 @@ > > ++"""Bond regression tests; run with python3 -m unittest discover -s tests/unit.""" > > These tests don't run when doing a `make deb` with our (downstream) > packaging: > > dh_auto_test -O--buildsystem=pybuild > I: pybuild base:311: cd > [..]ifupdown2/ifupdown2-3.3.0-1+pmx12/.pybuild/cpython3_3.13_ifupdown2/build; > python3.13 -m unittest discover -v > > ---------------------------------------------------------------------- > Ran 0 tests in 0.000s > > NO TESTS RAN > > IMO would make sense to have them run on a `make deb` too. Hmm good catch, didn't run the tests :/ This should be fixed with something like: diff --git a/debian/rules b/debian/rules index cc9547dce6..0443852924 100755 --- a/debian/rules +++ b/debian/rules @@ -3,6 +3,7 @@ #export DH_VERBOSE=1 export PYBUILD_NAME=ifupdown2 export PYBUILD_INSTALL_ARGS=--install-lib=/usr/share/ --install-scripts=/usr/share/ +export PYBUILD_TEST_ARGS=--start-directory {dir}/tests/unit %: dh $@ --with=python3 --buildsystem=pybuild I'll send a patch. Thanks for the review!