From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B271B1FF140 for ; Fri, 27 Mar 2026 10:12:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0AD3836D6B; Fri, 27 Mar 2026 10:13:01 +0100 (CET) Date: Fri, 27 Mar 2026 10:12:26 +0100 From: Gabriel Goller To: Shannon Sterz , pve-devel@lists.proxmox.com Subject: Re: [PATCH proxmox-ve-rs v7 02/21] frr: add proxmox-frr-templates package that contains templates Message-ID: Mail-Followup-To: Shannon Sterz , pve-devel@lists.proxmox.com, Thomas Lamprecht References: <20260323134934.243110-1-g.goller@proxmox.com> <20260323134934.243110-3-g.goller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774602696278 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZBGUQ43VMPX7S76SNS2LJGVNCBQ3EI4Z X-Message-ID-Hash: ZBGUQ43VMPX7S76SNS2LJGVNCBQ3EI4Z X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Lamprecht X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 27.03.2026 10:07, Gabriel Goller wrote: > On 26.03.2026 16:15, Shannon Sterz wrote: > > On Mon Mar 23, 2026 at 2:48 PM CET, Gabriel Goller wrote: > > > This debian package contains the jinja template files used to generate > > > the frr config. Currently only the fabrics template files are here, the > > > rest will be added in later commits. When installing this package the > > > templates will be installed to `/usr/share/proxmox-frr/templates/`. > > > `proxmox-frr` will then use `include_str!` to embed the templates into > > > the binary. > > > > > > This package will only be published to the `devel` channel. > > > > > > Reviewed-by: Hannes Laimer > > > Tested-by: Stefan Hanreich > > > Co-authored-by: Stefan Hanreich > > > Signed-off-by: Gabriel Goller > > > --- > > > Makefile | 8 +++ > > > proxmox-frr-templates/.gitignore | 1 + > > > proxmox-frr-templates/Makefile | 50 +++++++++++++++++++ > > > proxmox-frr-templates/debian/changelog | 5 ++ > > > proxmox-frr-templates/debian/control | 17 +++++++ > > > proxmox-frr-templates/debian/copyright | 18 +++++++ > > > .../debian/proxmox-frr-templates.install | 1 + > > > proxmox-frr-templates/debian/rules | 5 ++ > > > .../templates/access_lists.jinja | 6 +++ > > > proxmox-frr-templates/templates/fabricd.jinja | 29 +++++++++++ > > > .../templates/frr.conf.jinja | 5 ++ > > > .../templates/interface.jinja | 12 +++++ > > > proxmox-frr-templates/templates/ospfd.jinja | 18 +++++++ > > > .../templates/protocol_routemaps.jinja | 10 ++++ > > > .../templates/route_maps.jinja | 22 ++++++++ > > > 15 files changed, 207 insertions(+) > > > create mode 100644 proxmox-frr-templates/.gitignore > > > create mode 100644 proxmox-frr-templates/Makefile > > > create mode 100644 proxmox-frr-templates/debian/changelog > > > create mode 100644 proxmox-frr-templates/debian/control > > > create mode 100644 proxmox-frr-templates/debian/copyright > > > create mode 100644 proxmox-frr-templates/debian/proxmox-frr-templates.install > > > create mode 100755 proxmox-frr-templates/debian/rules > > > create mode 100644 proxmox-frr-templates/templates/access_lists.jinja > > > create mode 100644 proxmox-frr-templates/templates/fabricd.jinja > > > create mode 100644 proxmox-frr-templates/templates/frr.conf.jinja > > > create mode 100644 proxmox-frr-templates/templates/interface.jinja > > > create mode 100644 proxmox-frr-templates/templates/ospfd.jinja > > > create mode 100644 proxmox-frr-templates/templates/protocol_routemaps.jinja > > > create mode 100644 proxmox-frr-templates/templates/route_maps.jinja > > > > > > [snip] > > > diff --git a/proxmox-frr-templates/debian/copyright b/proxmox-frr-templates/debian/copyright > > > new file mode 100644 > > > index 000000000000..1ea8a56b4f58 > > > --- /dev/null > > > +++ b/proxmox-frr-templates/debian/copyright > > > @@ -0,0 +1,18 @@ > > > +Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ > > > + > > > +Files: > > > + * > > > +Copyright: 2019 - 2025 Proxmox Server Solutions GmbH > > > > tiny nit: but it's 2026 already ;) > > Fixed it, thanks for the review! Oh, I noticed every crate in ve-rs is on 2025. Should I update them all? Or do we only update the new crates (so proxmox-frr-templates)? @Thomas? > > > +License: AGPL-3.0-or-later > > > + This program is free software: you can redistribute it and/or modify it under > > > + the terms of the GNU Affero General Public License as published by the Free > > > + Software Foundation, either version 3 of the License, or (at your option) any > > > + later version. > > > + . > > > + This program is distributed in the hope that it will be useful, but WITHOUT > > > + ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS > > > + FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more > > > + details. > > > + . > > > + You should have received a copy of the GNU Affero General Public License along > > > + with this program. If not, see .