From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A9B4C1FF09B for ; Mon, 31 Aug 2026 11:29:12 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 244BD2126C; Mon, 31 Aug 2026 11:29:12 +0200 (CEST) Date: Mon, 31 Aug 2026 11:29:07 +0200 From: Gabriel Goller To: Cole Hughes Subject: Re: [PATCH docs 1/3] sdn: removing ASN number Message-ID: Mail-Followup-To: Cole Hughes , pve-devel@lists.proxmox.com References: <20260828182412.47042-1-c.hughes@proxmox.com> <20260828182412.47042-2-c.hughes@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260828182412.47042-2-c.hughes@proxmox.com> User-Agent: NeoMutt/20260504 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788168534999 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.382 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YHYKKB6JON6AOFZTVSBSKLSEAJOGWW47 X-Message-ID-Hash: YHYKKB6JON6AOFZTVSBSKLSEAJOGWW47 X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks! A few small nits inline, if fixed in the next version you can consider: Reviewed-by: Gabriel Goller On 28.08.2026 14:24, Cole Hughes wrote: > [snip] > diff --git a/pvesdn.adoc b/pvesdn.adoc > index 3fd3533..ebf0c89 100644 > --- a/pvesdn.adoc > +++ b/pvesdn.adoc > @@ -465,8 +465,8 @@ xref:pvesdn_install_frrouting[install FRRouting]. > > EVPN controller configuration options: > > -ASN #:: A unique BGP ASN number. It's highly recommended to use a private ASN > - number (64512 – 65534, 4200000000 – 4294967294), as otherwise you could end up > +ASN:: A unique BGP ASN. It's highly recommended to use a private ASN > + (64512 – 65534, 4200000000 – 4294967294), as otherwise you could end up > breaking global routing by mistake. Every EVPN controller configured on a node > must have the same ASN configured. > > @@ -516,7 +516,7 @@ Otherwise, if an EVPN controller is configured, then the ASN from the EVPN > controller is used - otherwise the ASN from the BGP controller. > > The SDN stack utilizes the local-as directive together with the `no-prepend > -replace-as` option in the FRR configuration for handling multiple ASN numbers in > +replace-as` option in the FRR configuration for handling multiple ASN in This should be "ASNs" instead of "ASN". > the configuration. This is the case when the BGP and EVPN controller have > different ASNs configured and auto mode is disabled. > > @@ -557,8 +557,8 @@ BGP controller configuration options: > > Node:: The node of this BGP controller > > -ASN #:: A unique BGP ASN number. It's highly recommended to use a private ASN > - number in the range (64512 - 65534) or (4200000000 - 4294967294), as otherwise > +ASN:: A unique BGP ASN. It's highly recommended to use a private ASN > + in the range (64512 - 65534) or (4200000000 - 4294967294), as otherwise > you could break global routing by mistake. > > Peer:: A list of peer IP addresses you want to communicate with using the > @@ -1193,7 +1193,7 @@ Node:: Select the node which will be added to the fabric. Only nodes that are > currently in the cluster will be shown. > > ASN:: BGP Autonomous System Number for this node. It is recommended to use > -private ASN numbers (64512-65534 for 16-bit, 4200000000-4294967294 for 32-bit). > +private ASN (64512-65534 for 16-bit, 4200000000-4294967294 for 32-bit). I'd use "a private ASN" here. > IPv4:: A unique IPv4 address for this node, also used as the BGP router-id. > Required when the fabric has an IPv4 prefix configured; each node in the same > @@ -1772,12 +1772,12 @@ EVPN Setup Example > The example assumes a cluster with three nodes (node1, node2, node3) with IP > addresses 192.168.0.1, 192.168.0.2 and 192.168.0.3. > > -Create an EVPN controller, using a private ASN number and the above node > +Create an EVPN controller, using a private ASN and the above node > addresses as peers. > [snip]