From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id E1F211FF0C1 for ; Tue, 25 Aug 2026 10:11:28 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 31E71218A1; Tue, 25 Aug 2026 10:09:49 +0200 (CEST) X-Envelope-To: pve-devel@lists.proxmox.com DKIM-Signature: a=rsa-sha256; bh=5vi7dc6hpnL8BNeKe5lx7OKlvlsRrXwYqQnVFwsJZqU=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1787593938; v=1; x=1788198738; b=kjUGUAqZH9EV05PXCHv6u8w4Ky4EX+y3TDJwxBkRssFX1egkwlNto2DC1IY4wCyj0aNrAFm/ EsIbdoqSBwNEqFnDWjQs6k7YRnhyDM4aZeFYvr/+5gcaSFcRVToo83ZVBfl6R5ua9ytmVtUDoOR 8vU9GqrDCemEoYRFagwQSjNk= X-Envelope-To: pve-devel@lists.proxmox.com X-Mizu-Trace-ID: 8d03184df8fa0905 X-Migadu-Flow: FLOW_OUT Date: Mon, 24 Aug 2026 12:52:03 -0500 From: Kent Overstreet To: pve-devel@lists.proxmox.com Subject: Re: [PATCH pve-kernel] build: ship Rust artifacts for external modules Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260812162527.98882-1-krzysztof@hajdamowicz.info> X-SPAM-LEVEL: Spam detection results: 0 DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: kent.overstreet@linux.dev X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: MFGUO37LFFVC7RXLWGBSOXXYRT5ZO3CJ X-Message-ID-Hash: MFGUO37LFFVC7RXLWGBSOXXYRT5ZO3CJ X-Mailman-Approved-At: Tue, 25 Aug 2026 10:09:15 +0200 CC: Krzysztof Hajdamowicz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Late followup, because I only checked yesterday and noticed that the testing on this patch was a snafu. (_why_ would you send out a patch that you weren't able to successfully test end to end yourself? I am still scratching my head on that one). However - the patch is correct, the screwup was just trying to build bcachefs with a different rustc than the kernel was built with - proxmox kernels build with rustc from trixie-backports. I've tested it end to end, and the patch is good and follows what Ubuntu is doing: Linux farm2-kvm 7.0.14-14-pve #1 SMP PREEMPT_DYNAMIC PMX 7.0.14-14 (2026-08-22T15:01Z) CONFIG_RUSTC_VERSION_TEXT="rustc 1.94.1 (e408947bf 2026-03-25) (built from a source tarball)" [5.383] bcachefs: loading out-of-tree module taints kernel. [5.482] bcachefs: bch2_dirent_init() ... vermagic: 7.0.14-14-pve SMP preempt mod_unload modversions [5.574] starting version need_discard_by_journal_seq (1.38) [5.574] Rust support enabled [5.575] bcachefs (vdb): initializing new filesystem [5.578] bcachefs (vdb): going read-write ... 64M O_DIRECT write, umount, remount, sha1sum -c OK, fsck clean ========= PASSED pve_module in 2s TEST SUCCESS As a reminder, every other distro is either shipping the Rust build artifacts or supports reproducible kernel builds; this patch is necessary for bcachefs to continue supporting Proxmox. Cheers, Kent