From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3B9F8BBE32 for ; Wed, 20 Dec 2023 10:40:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1FB89AB2A for ; Wed, 20 Dec 2023 10:40:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 20 Dec 2023 10:40:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D6AD4487CB for ; Wed, 20 Dec 2023 10:40:20 +0100 (CET) Date: Wed, 20 Dec 2023 10:40:20 +0100 From: Christoph Heiss To: Maximiliano Sandoval Cc: pve-devel@lists.proxmox.com Message-ID: References: <20231121151025.233224-1-m.sandoval@proxmox.com> <20231121151025.233224-3-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH installer v2 2/7] gui: expand ip address Gtk3::Entry X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2023 09:40:22 -0000 On Fri, Dec 15, 2023 at 03:08:48PM +0100, Maximiliano Sandoval wrote: > > > Christoph Heiss writes: > > > On Tue, Nov 21, 2023 at 04:10:20PM +0100, Maximiliano Sandoval wrote: > >> > >> This accounts for the different layout set in the previous commit. > > > > What commit is meant here exactly? The previous patch in this series > > (aka. the first) does not change any layout as it's a simple code move, > > right? > > > > Good catch, in v1 this commit went directly after the commit > > gui: use basic grid in the network panel Makes sense then, I figured that. > > which contains the mentioned changes. Should this require a v3? >From my side, no, if nothing else comes up. If really needed it could be fixed up when committing at the very latest. > > -- > Maximiliano