From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id E5A501FF0B7
	for <inbox@lore.proxmox.com>; Fri, 16 Oct 2026 15:43:48 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 378EB214D5;
	Fri, 16 Oct 2026 15:43:46 +0200 (CEST)
Date: Fri, 16 Oct 2026 15:43:42 +0200
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Lukas Sichert <l.sichert@proxmox.com>
Subject: Re: [PATCH perl-rs 2/3] common: enable strict and warnings in perl
 package modules
Message-ID: <alel3zestzlvn5dvwwpzpok76tenr5hzwugom6c44uhz2ighl7@fiaadcxcxbe2>
References: <20261015154243.304235-1-l.sichert@proxmox.com>
 <20261015154243.304235-3-l.sichert@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20261015154243.304235-3-l.sichert@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1792158222209
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.456 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: UJ5R2OECHXTT6LMR3XQH7Q37UHULR4MZ
X-Message-ID-Hash: UJ5R2OECHXTT6LMR3XQH7Q37UHULR4MZ
X-MailFrom: w.bumiller@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Thu, Oct 15, 2026 at 05:42:40PM +0200, Lukas Sichert wrote:
> The Proxmox style guide requires every perl module to enable both
> pragmas, but PVE::RS::CalendarEvent and Proxmox::Lib::Common did not.
> 
> Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
> ---
>  common/pkg/PVE/RS/CalendarEvent.pm | 3 +++
>  common/pkg/Proxmox/Lib/Common.pm   | 3 +++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/common/pkg/PVE/RS/CalendarEvent.pm b/common/pkg/PVE/RS/CalendarEvent.pm
> index 3a5f66e..47946f8 100644
> --- a/common/pkg/PVE/RS/CalendarEvent.pm
> +++ b/common/pkg/PVE/RS/CalendarEvent.pm
> @@ -1,3 +1,6 @@
> +use strict;
> +use warnings;
> +

This is rather useless in this file.

This is a deprecated file of which the last user, as far as I can tell,
was fixed 4 years ago, so we should delete it instead.

>  use base 'Proxmox::RS::CalendarEvent';
>  # Compat, Deprecated!
>  1
> diff --git a/common/pkg/Proxmox/Lib/Common.pm b/common/pkg/Proxmox/Lib/Common.pm
> index 1e6b26d..1074050 100644
> --- a/common/pkg/Proxmox/Lib/Common.pm
> +++ b/common/pkg/Proxmox/Lib/Common.pm
> @@ -22,6 +22,9 @@ whichever was loaded.
>  
>  =cut
>  
> +use strict;
> +use warnings;
> +
>  use vars qw(@ISA);
>  
>  sub library {
> -- 
> 2.47.3
> 
> 
> 
> 
> 

--