From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1FFCE906C1 for ; Thu, 16 Mar 2023 11:53:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 02A31320D for ; Thu, 16 Mar 2023 11:53:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 16 Mar 2023 11:53:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 90F6B43628 for ; Thu, 16 Mar 2023 11:53:05 +0100 (CET) Message-ID: Date: Thu, 16 Mar 2023 11:53:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:111.0) Gecko/20100101 Thunderbird/111.0 Content-Language: en-GB, de-AT To: Proxmox VE development discussion , Fiona Ebner References: <20230315144422.139303-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230315144422.139303-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH guest-common] fix #4572: config: also update volume IDs in pending section X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Mar 2023 10:53:07 -0000 Am 15/03/2023 um 15:44 schrieb Fiona Ebner: > The method is intended to be used in cases where the volumes actually > got renamed (e.g. migration). Thus, updating the volume IDs should of > course also be done for pending changes to avoid changes referring to > now non-existent volumes or even the wrong existing volume. > > Signed-off-by: Fiona Ebner > --- > src/PVE/AbstractConfig.pm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > applied, thanks! as talked off-list, I wrapped this and the pre-existing $conf->{snapshot} access into an if-defined guard, just to be sure as autovivifiaction and undef-warns can be both a nuisance.