Re: [pve-devel] [PATCH pve_flutter_frontend v2 2/2] fix: ui: guests missing in resources tab when status is `paused`

["Michael Köppl" <m.koeppl@proxmox.com>]

On 6/2/25 15:37, Shan Shaji wrote:
> When the guest status is set to `paused` the guest was not showing in
> the resources tab. Also there were no option in the resources
> filter to select the `paused` status under the status section.

The first sentence confused me a bit. The resource tab seems to show the
guest for me, but displays its status as "Unknown". That is fixed by the
following patch. This patch "only" adds the filter. I think a commit
message like "resources: add filter option for paused guest status"
would be more appropriate.

> 
> This commit fixes the issue by adding the `paused` status under the
> status section in the resources filter sheet.

nit: the commit message should not contain "This commit...".


> 
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>  
>  changes since v1:
>  * Removed all formatting changes. 
>  * New `paused` status option is added after refactoring the filter sheet. 
>  
>  lib/widgets/pve_mobile_resource_filter_sheet.dart | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/lib/widgets/pve_mobile_resource_filter_sheet.dart b/lib/widgets/pve_mobile_resource_filter_sheet.dart
> index cee3a49..c09b2cf 100644
> --- a/lib/widgets/pve_mobile_resource_filter_sheet.dart
> +++ b/lib/widgets/pve_mobile_resource_filter_sheet.dart
> @@ -112,6 +112,20 @@ class PveMobileResourceFilterSheet extends StatelessWidget {
>                        ),
>                      ),
>                    ),
> +                  _ProxmoxResourceFilterListTile(
> +                    title: 'Paused',
> +                    value: state.statusFilter
> +                        .contains(PveResourceStatusType.paused),
> +                    onChanged: (v) => rBloc.events.add(
> +                      FilterResources(
> +                        statusFilter: _addOrRemove(
> +                          v!,
> +                          PveResourceStatusType.paused,
> +                          state.statusFilter,
> +                        ),
> +                      ),
> +                    ),
> +                  ),

Could make sense to do something like this:
_PveFilterSheetSection(
  sectionTitle: 'Status',
  items: [
    for (var statusFilterItem in [
      ('Online', PveResourceStatusType.running),
      ('Offline', PveResourceStatusType.stopped),
      ('Paused', PveResourceStatusType.paused),
    ]) _ProxmoxResourceFilterListTile(
      title: statusFilterItem.$1,
      value: state.statusFilter
          .contains(statusFilterItem.$2),
      onChanged: (v) => rBloc.events.add(
        FilterResources(
          statusFilter: _addOrRemove(
            v!,
            statusFilterItem.$2,
            state.statusFilter,
          ),
        ),
      ),
    ),
  ],
)

instead of copying the entire _ProxmoxResourceFilterListTile every time
we want to add another status as a filter. Not directly related to this
patch, just a suggestion. If you do send a v3 including this, it should
probably be a separate patch.

>                  ],
>                )
>              ],




_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel