From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id 80A096AF72 for ; Mon, 2 Aug 2021 16:37:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id 794499920 for ; Mon, 2 Aug 2021 16:37:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id 569CF9910 for ; Mon, 2 Aug 2021 16:37:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id 262D340E7F; Mon, 2 Aug 2021 16:37:36 +0200 (CEST) Message-ID: Date: Mon, 2 Aug 2021 16:37:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-US To: Proxmox VE development discussion , Lorenz Stechauner References: <20210722130631.237107-1-l.stechauner@proxmox.com> <20210722130631.237107-8-l.stechauner@proxmox.com> From: Dominik Csapak In-Reply-To: <20210722130631.237107-8-l.stechauner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.526 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.08 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 manager 3/5] ui/UploadToStorage: add checksum and algorithm X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Aug 2021 14:37:37 -0000 comments inline On 7/22/21 15:06, Lorenz Stechauner wrote: > Signed-off-by: Lorenz Stechauner > --- > www/manager6/window/UploadToStorage.js | 32 ++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js > index fb9850b3..0b4d991a 100644 > --- a/www/manager6/window/UploadToStorage.js > +++ b/www/manager6/window/UploadToStorage.js > @@ -130,6 +130,18 @@ Ext.define('PVE.window.UploadToStorage', { > vm.set('size', (fileInput.files[0] && Proxmox.Utils.format_size(fileInput.files[0].size)) || '-'); > vm.set('mimetype', (fileInput.files[0] && fileInput.files[0].type) || '-'); > }, > + > + hashChange: function(field) { > + const checksum = Ext.getCmp('downloadUrlChecksum'); since we already have a controller, please use 'reference' instead of id, and 'this.lookup' instead of Ext.getCmp > + if (field.getValue() === '__default__') { the second parameter of the change event is the value, so you could omit the call to getValue here.. > + checksum.setDisabled(true); > + checksum.setValue(""); > + checksum.allowBlank = true; is this correct? wouldn't it be checksum.setAllowBlank ? also why set that in the first place? just leave it set to 'false'. Disabled fields will not get submitted or calculated on form validation anyway > + } else { > + checksum.setDisabled(false); > + checksum.allowBlank = false; > + } > + }, > }, > > items: [ > @@ -184,6 +196,26 @@ Ext.define('PVE.window.UploadToStorage', { > value: '{mimetype}', > }, > }, > + { > + xtype: 'pveHashAlgorithmSelector', > + name: 'checksum-algorithm', > + fieldLabel: gettext('Hash algorithm'), > + allowBlank: true, > + hasNoneOption: true, > + value: '__default__', > + listeners: { > + change: 'hashChange', > + }, > + }, > + { > + xtype: 'textfield', > + name: 'checksum', > + fieldLabel: gettext('Checksum'), > + allowBlank: true, > + disabled: true, > + emptyText: gettext('none'), > + id: 'downloadUrlChecksum', > + }, > { > xtype: 'progressbar', > text: 'Ready', >