From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5D5C31FF179 for ; Wed, 29 Oct 2025 14:14:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B79F6A45B; Wed, 29 Oct 2025 14:15:17 +0100 (CET) Message-ID: Date: Wed, 29 Oct 2025 14:14:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta From: Dominik Csapak To: pve-devel@lists.proxmox.com References: <20251029131256.3124803-1-d.csapak@proxmox.com> Content-Language: en-US In-Reply-To: <20251029131256.3124803-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761743672821 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v2] ui: properly reset API 401 count X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" i forgot to add Fionas R-b trailer... sorry! just holler if i should send a v3 for that... On 10/29/25 2:13 PM, Dominik Csapak wrote: > due to a timing race condition, it can happen that we try to increase > the 401 count before resetting it (which happens after the first > ticket api call). Since `undefined + ` === NaN, our later check for > `> 5` never triggers and we don't show the login mask, but an empty > window. > > To fix this, initialize the variable always with 0. > > Observed when restoring a session after a ticket expired while the > browser was closed. > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * rebase on master > > www/manager6/Workspace.js | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js > index a2574658..60c499cb 100644 > --- a/www/manager6/Workspace.js > +++ b/www/manager6/Workspace.js > @@ -13,6 +13,8 @@ Ext.define('PVE.Workspace', { > > loginData: null, // Data from last login call > > + response401count: 0, > + > onLogin: function (loginData) { > // override me > }, _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel