From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7938A9166 for ; Thu, 17 Nov 2022 13:13:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5250D2C028 for ; Thu, 17 Nov 2022 13:12:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 17 Nov 2022 13:12:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D2D04406E1 for ; Thu, 17 Nov 2022 13:12:32 +0100 (CET) Message-ID: Date: Thu, 17 Nov 2022 13:12:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak References: <20221116154815.358385-1-d.csapak@proxmox.com> <20221116154815.358385-7-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221116154815.358385-7-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL -0.031 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH guest-common v11 1/1] GuestHelpers: add tag related helpers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2022 12:13:04 -0000 Am 16/11/2022 um 16:48 schrieb Dominik Csapak: > 'get_allowed_tags': > returns the allowed tags for the given user > > 'assert_tag_permissions' > helper to check permissions for tag setting/updating/deleting > for both container and qemu-server > > gets the list of allowed tags from the DataCenterConfig and the current > user permissions, and checks for each tag that is added/removed if > the user has permissions to modify it > > 'normal' tags require 'VM.Config.Options' on '/vms/', but not > allowed tags (either limited with 'user-tag-access' or > 'privileged-tags' in the datacenter.cfg) requrie 'Sys.Modify' on '/' > > Signed-off-by: Dominik Csapak > --- > debian/control | 3 +- > src/PVE/GuestHelpers.pm | 99 ++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 100 insertions(+), 2 deletions(-) > > applied, thanks!