From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 08F2F768E7 for ; Tue, 19 Oct 2021 15:54:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 057062E9B0 for ; Tue, 19 Oct 2021 15:54:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0723D2E992 for ; Tue, 19 Oct 2021 15:54:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D3F73468F4 for ; Tue, 19 Oct 2021 15:53:59 +0200 (CEST) To: Proxmox VE development discussion , Dominik Csapak References: <20211005112903.3649291-1-d.csapak@proxmox.com> From: Lorenz Stechauner Message-ID: Date: Tue, 19 Oct 2021 15:53:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211005112903.3649291-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.390 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v3 0/7] multi disk/mp in wizard X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2021 13:54:01 -0000 Hi, everything looks and works as expected. No disk/mount point window looks broken. Tested VM/CT creation wizard and adding of disks/mount points afterwards. Tested-By: Lorenz Stechauner On 05.10.21 13:28, Dominik Csapak wrote: > this series is a continuation of my previous multi tab / disk series[0] > > Introduces multi disk panels for vm and containers in the wizard. > > The UX is modeled after Dominics first attempt, but a very different > approach code-wise. instead of having a seperate 'data' panel that > contains the vm config, let the multi disk panel handle that > and pass it through to the panels below. this way the HDEdit does > not need a big code-change to get/set the config. > > changes from v2: > * rebase on master (multi tab disk panel already applied) > * refactor multi disk panel so that we can reuse it for containers > * implement multi mp panel for container > > changes from v1: > * fixed a bug which prevented the wizard from finishing > * made the wizard a little wider so that the form field labes are > readable > * added logic to use the ostype to determine the first disk if one > deleted all before > > 0: https://lists.proxmox.com/pipermail/pve-devel/2021-October/050215.html > > Dominik Csapak (7): > ui: lxc/MPEdit: add updateVMConfig > ui: lxc/MPEdit: fire diskidchange event > ui: lxc/MPEdit: add selectFree toggle > ui: add MultiDiskPanel > ui: add lxc/MultiMPEdit and use in lxc/CreateWizard > ui: add qemu/MultiHDEdit and use it in the wizard > ui: window/Wizard: make it a little wider > > www/manager6/Makefile | 3 + > www/manager6/lxc/CreateWizard.js | 8 +- > www/manager6/lxc/MPEdit.js | 16 +- > www/manager6/lxc/MultiMPEdit.js | 79 ++++++++ > www/manager6/panel/MultiDiskEdit.js | 272 ++++++++++++++++++++++++++++ > www/manager6/qemu/CreateWizard.js | 7 +- > www/manager6/qemu/HDEdit.js | 9 +- > www/manager6/qemu/MultiHDEdit.js | 62 +++++++ > www/manager6/window/Wizard.js | 2 +- > 9 files changed, 444 insertions(+), 14 deletions(-) > create mode 100644 www/manager6/lxc/MultiMPEdit.js > create mode 100644 www/manager6/panel/MultiDiskEdit.js > create mode 100644 www/manager6/qemu/MultiHDEdit.js >