From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 811A872C4C for ; Wed, 16 Jun 2021 16:28:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7382F12BBB for ; Wed, 16 Jun 2021 16:28:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AD45612BAD for ; Wed, 16 Jun 2021 16:28:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7F98444114 for ; Wed, 16 Jun 2021 16:28:00 +0200 (CEST) Message-ID: Date: Wed, 16 Jun 2021 16:27:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20210616135534.4798-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210616135534.4798-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.756 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.095 Looks like a legit reply (A) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, accesscontrol.pm] Subject: Re: [pve-devel] [PATCH access-control v2] add missing paths in check_path X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jun 2021 14:28:01 -0000 On 16.06.21 15:55, Dominik Csapak wrote: > * /access/realm/ > * /access/groups/ > > were overlooked when fixing #1500 > > see: https://forum.proxmox.com/threads/are-group-acls-broken-in-v6-4.91000/ > > Signed-off-by: Dominik Csapak > --- > supersedes my earlier patch: > https://lists.proxmox.com/pipermail/pve-devel/2021-June/048704.html > > changes: > * also add missing group paths > > src/PVE/AccessControl.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm > index 888875e..9619c7d 100644 > --- a/src/PVE/AccessControl.pm > +++ b/src/PVE/AccessControl.pm > @@ -939,7 +939,9 @@ sub check_path { > / > |/access > |/access/groups > + |/access/groups/[[:alnum:]\.\-\_]+ > |/access/realm > + |/access/realm/[[:alnum:]\.\-\_]+ > |/nodes > |/nodes/[[:alnum:]\.\-\_]+ > |/pool > also backported to stable-6, and those sub-paths are missing in the UI's "path proposal" generator for the combobox's store, can you please send a patch to add them there too (master only)?