From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <a.lauterer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id C1969697BD
 for <pve-devel@lists.proxmox.com>; Thu, 24 Mar 2022 11:44:56 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id B7C882EC3D
 for <pve-devel@lists.proxmox.com>; Thu, 24 Mar 2022 11:44:56 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 514B22EC32
 for <pve-devel@lists.proxmox.com>; Thu, 24 Mar 2022 11:44:56 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1B6F946F4D
 for <pve-devel@lists.proxmox.com>; Thu, 24 Mar 2022 11:44:50 +0100 (CET)
Message-ID: <ad3d9724-a4a3-1fce-5b62-988f471f7c78@proxmox.com>
Date: Thu, 24 Mar 2022 11:44:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-US
To: Fabian Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
References: <20220314093509.349554-1-a.lauterer@proxmox.com>
 <20220314093509.349554-7-a.lauterer@proxmox.com>
 <cbae4fd6-db20-3d86-1114-4e83231719e7@proxmox.com>
From: Aaron Lauterer <a.lauterer@proxmox.com>
In-Reply-To: <cbae4fd6-db20-3d86-1114-4e83231719e7@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.025 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pve-devel] [PATCH v4 manager 6/6] ui: util: refactor mps to mp
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 24 Mar 2022 10:44:56 -0000



On 3/22/22 12:18, Fabian Ebner wrote:
> Am 14.03.22 um 10:35 schrieb Aaron Lauterer:
>> @@ -1805,9 +1805,7 @@ Ext.define('PVE.Utils', {
>>       },
>>   
>>       nextFreeMP: function(type, config) {
>> -	let mptype = type === "mp" ? "mps" : type;
>> -
>> -	for (let i = 0; i < PVE.Utils.mp_counts[mptype]; i++) {
>> +	for (let i = 0; i < PVE.Utils.mp_counts[type]; i++) {
>>   	    let confid = `${type}${i}`;
>>   	    if (!Ext.isDefined(config[confid])) {
>>   		return {
> 
> Nit: If this patch were ordered before the first one, we could start out
> with the simpler version.

True but I went with the approach to make this change optional. That's why it is the last in the series.